Limit as textfield, instead of select list

#377858: limit as textfield, instead of select list, Drupal 5 is a request for a backport of this. #196250: Invitation limit should not be an input field raises an issue that needs consideration before this can be marked RTBC. The patch is clean and works.

Rerolling for dev branch. Still needs work due to issues raised in #196250: Invitation limit should not be an input field

This version of the patch addresses the issue raised in #196250: Invitation limit should not be an input field by validating the user input values for role limits. It needs review and some testing.

user_roles(0) looks scary. Why?

It is not using user_roles(0) to set any values, just to find keys of values in the form submission ($form_state['values']). I copied this iteration technique from:

function invite_settings() {
  $roles = user_roles(0, 'send invitations');
  // ...

  foreach ($roles as $role) {
    $role_no_space = str_replace(' ', '_', $role);
    $form['role'][$role_no_space] = array(
      '#type' => 'fieldset',
      '#title' => t('@role settings', array('@role' => drupal_ucfirst($role))),
      '#collapsible' => TRUE,
      '#collapsed' => TRUE,
    );
    // ...
  }
  // ...
}

There are 5 other places in invite.module and invite.install that already use user_roles(0) in this way (and one that uses user_roles(1)).

Ideally they would use booleans FALSE and TRUE instead of integers, but that is a separate issue.

Also, in this case, passing any different parameters such as user_roles(1) would be an error, since users invited by anonymous users would not gain anonymous users' target role. Though implementing invite.module in this way would probably be an error of it's own (on the part of the configurator)!

I am closing this issue, since it's for a Drupal version no longer supported.