Using role-names instead of ids caused problems with other languages [#443916]

I had some irregularities with proper assigning of the maximum invites allowed to send by role.
After reviewing the code, I found the bug.

In invite_get_role_limit, we compare the names of $account->roles with names of the results user_roles().
As long as we use only English, this is not a problem. Although the version with $role_no_space is not very nice.
But when we use another language than English, we compare the translated role-names of $account-roles with the untranslated ones of user_roles().

My suggestion: let's use the roles id's instead of the names.
I tried to change every position where the names were used to the id-using behaviour.

Comment	File	Size	Author
#2	invite-role_ids.patch	5.09 KB	smk-ka
	invite_admin.inc_.patch	1.99 KB	guldi
	invite.module.patch	1.6 KB	guldi

Comments

Comment #1

guldi commented 5 May 2009 at 10:18

Could someone please have a look at this?

Comment #2

smk-ka commented 5 May 2009 at 12:17

Status	File	Size
new	invite-role_ids.patch	5.09 KB

This looks good to me except that the default target role setting was lost, so I've put it back in.
All we need now is an update function that performs the role names to rid conversion.

Comment #3

guldi commented 11 May 2009 at 14:45

This should be it.

Would be glad if you could check it...

  $result = db_query('SELECT * FROM {role} ORDER BY name');
	while($role = db_fetch_object($result)) {
		$role_no_space = str_replace(' ', '_', t($role->name));
		$query1 = db_query("UPDATE {variable} SET name='%s' WHERE name='%s'",'invite_maxnum_'.$role->rid,'invite_maxnum_'.$role_no_space);
		$query2 = db_query("UPDATE {variable} SET name='%s' WHERE name='%s'",'invite_target_role_'.$role->rid,'invite_target_role_'.$role_no_space);
	}