Version of invite for Drupal 6

yeah, code needs review for d6 :) invite.module is important module for social networking.

is this module will upgrade ? if it wont upgrade, i need to turn drupal5 again :) any explanation ?

Any word on this now that we are at 6.2? This is a fantastic module and it would be really nice to see this come up to speed with the current version of Drupal.

Great module!
It would be great to see this module for drupal 6 :)
subscribing ;-)

The token module has a pretty stable release out now:

http://drupal.org/project/token

so it's only a matter of time. Subscribing! :)

subscribing

There doesn't appear to be any work started upgrading the module to 6.x. From the project page I'm guessing the roadmap would be to get out 5.x-2.x first.

subscribe (and sit patiently.

subscribing

subscribing

subscribing

subscribing.

... it would be nicer to see some roughly working patch for D6 at the first stage.

I'm guessing an invite upgrade should be based off of the 5.x-2.x branch...

Alright! Enjoy! It's invite for Drupal 6!

Please try it out.

Yeah, forgot to change the status...

That's against the 5.x-2.x branch, btw.

Heh. Some debugging code was left in by mistake...

Cool! I'll test it and report back.

Hi,

thank you very much for the patch.

I don't know what I missed, I patched 5.x-2.x-dev successfully and uploaded the files to my sites/all/modules folder and wanted to enable it, but it still says, that it isn't compatible with my 6.3 version of the Drupal core.

Can you help me with that?

Ben

Hi,

was my fault. The patch didn't worked properly for me, patched all files but the .info files. So I patched them manually and could install the module.
Everything works out fine (Thank you for this great patch) and the module is working. But I have the impression that my site is significantly slowing down since I installed the module...
Have you any idea what I can optimize to speed it up again...

Benedikt

Hi jcfiala and others,

I've been also porting Invite.module. After several hours of porting I take this issue into account. Jcfiala's version was more mature, so I take it and merge it with my changes.

Changes compared to jcfiala's second version:

- repaired some minor bugs (ie. wrong order of arguments in theme function)
- functions in invite_admin are called directly from menu (via "file" Menu API argument)
- all "title callbacks" in hook_menu changed to "title", title callback (???) doesn't work for me, I never ever hear about it
- cleaned some commented code (ie. debug code or old install hook)

thanks ... perhaps reading the first hit on google would help: http://www.google.com/search?q=title+callback

Thanks moshe, I've asked chx on IRC this afternoon and he give me this link too. I've read some docs pages around, but I missed this one :-/

So here is new version of patch, I put back jcfiala's title callbacks functions. It seems that in D6.3 is needed to define even "title" or "title arguments" properties. Title callback alone doesn't seem to work.

Changes:

- title callbacks are back
- repaired broken hook_help

Any updated module that I can just download. Cant seem to get the patch to work

Recently I've found these minor bugs in invite_update_six_4.patch

1) one wrong menu definition
2) one query of the DB update failed

invite module
Update #6000
...    
    * Failed: ALTER TABLE {invite_notifications} DROP INDEX uid_invitee
...   

cerventus: Downloadable module will not be released until ea4tv will decide to release it. You have to use patches until this time. Patch works against latest 5.x-2.x-dev release (2008-Jul-13) not against HEAD. If you are on windows and using cygwin version of patch.exe, you have to convert line endigs from CR to CR-LF (i.e. unix to dos line endings) before patching.

Place patch in the invite directory and launch patch.exe from command line ... (You have to use p0 param = multiple patching files parameter).

patch.exe -p0 < invite_update_six_4.patch

subscribing

subscribing

subscribing

In addition to #24:

More integration to D6 FAPI should be made, i.e. $_SESSION['invite_failed_emails'] should be now stored in $form_state['values']['storage']['invite_failed_emails'].

Change the path from $items['invite/accept'] to $items['invite/accept/%'] according to D6 menu system.

New patch:
- Fixed hook_help.
- Fixed the remaining bits of the menu system (including the 'invite/accept/%invite' change wojtha proposed in #28).
- Adopted D6 drupal_mail() functionality.

Regarding invite.install:
- I've removed the conversion of database fields from signed to unsigned. These won't break anything after all.
- Since update_6000 is now gone, the failing query is gone, too (see #24).

Remaining to-dos:
- $_SESSION['invite_failed_emails'] should be now stored in $form_state['values']['storage']['invite_failed_emails'] (see #28).
- @wojtha: Which menu item isn't working (#24)?

The patch doesn't work with the latest 5.x-2.x-dev

@smk-ka It was my fault in the patch, I've implementing the menu system callbacks and left some code from docs in the patch. Path works, even in this case, there were only some "unwanted" lines :-)

+  $items['invite'] = array(
+    //'title' => variable_get('invite_page_title',  'Invite a friend'),
+    'title' => 'Invite a friend',
+    'title callback' => 'invite_path_title',
+    'title arguments' => array(t('Example title'), t('Case 4')),
+    'page callback' => 'drupal_get_form',

But I have a look at your latest patch and this item is repaired ;-)

@smk-ka, what is left to make this patch into a module - for someone to put the files together, tarball it, then post here or upload to d.o?

loved to see engagement here and would love to see a -dev package even more. Thanks for all the work so far!

Cheers!

For those who are not into patching - here is 5.x-2.x-dev patched with #29 patch (thanks smk-ka!). I did an admin test run - no errors. I DID NOT test this on a production site - be warned.

@wojtha, #31, I checked the new code and all is well.

Todo:
- $_SESSION['invite_failed_emails'] should be now stored in $form_state['values']['storage']['invite_failed_emails'] (see #28).
- The CHANGELOG and README need some comments.
- More testing...

Can someone explain what approach should be taken to move the $_SESSION['invite_failed_emails'] to $form_state['values']['storage']['invite_failed_emails']?

I understand why this should be done but I am not sure within what functions these changes need to be made. I assume $_SESSION['invite_failed_emails'] still needs to be used in function _invite_get_emails()? But then later push that session to using $form_state and unsetting the session value. If someone could explain a little I would like to try to take care of this "todo".

Thanks

@mcneelycorp: $_SESSION['invite_failed_emails'] was a workaround for saving some data in multipage forms. Since D6 you can store all validated data (or whatever data you want) in $form_state['storage']. There was also function form_set_value. But it allows setting values only for "validate" and "submit" part of the form runtime. In the form function, (where form was defined) you have no access to these values (via FAPI => you have to use $_POST or $_SESSION).

If you put something to "storage" it will stay there "forever" until you unset it.

ie If you want redirect the form after successful validation & submit you have to make sure that $form_state['storage'] is empty (unset($form_state['storage']);). If "storage" isn't empty, Drupal expects that you want to make something with these stored data and $form_state['redirect'] will not work.

  // If $form_state['storage'] or $form_state['rebuild'] have been
  // set by any submit or validate handlers, however, we know that
  // we're in a complex multi-part process of some sort and the form's
  // workflow is NOT complete. We need to construct a fresh copy of
  // the form, passing in the latest $form_state in addition to any
  // other variables passed into drupal_get_form().

See http://api.drupal.org/api/function/drupal_get_form/6

@smk-ka: please release new 6 dev version. There are lots of changes between the patches (ie between #24 and #29) and it is hard to follow changes.

@mcneelycorp: I make the patch against #34 invite-6.x-dev_ported.tar_.gz. I simply convert all $_SESSION['invite_failed_emails'] to $form_state['values']['storage'], because of that I add one parameter (&$form_state) to helper function _invite_get_emails.

I haven't test it yet so please test it & share your xp, I will not have time for testing it for couple of days.

@wojtha: 6.x branch has been created, a development snapshot should appear within the next 12 hours.

Thanks smk-ka. I will be using it in the coming days, will report any issues that are found. Thanks everyone for pushing this forward!

I reported 2 issues reg sql error and menu item..plz check them.

Thanks
Sunny

@sangamreddi Thanks! Both issues #303558: Typo error in SQL query and #303587: Invite withdraw leads to access denied page was fixed by smk-ka.

@wojtha Thanks.

Should we got with $_SESSION['invite_failed_emails'] or $form_state['values']['storage'] to store the emails during multi step.

if its in $_SESSION we can use other modules like dcl_importer to pass emails. if its $form_state['values']['storage'] how can we pass emails from other modules??

Is there any other way to work around on this??

Right now the invite module is still using the $_SESSION only not $form_state['values']['storage'], looks like the patch 37 didn't committed.

Thanks

Sunny

Thanks, smk-ka, for creating a -dev branch. I'm renaming this issue to reflect being a discussion about the D6 version/development.

Cheers.

sub

subscribing

subscribing!

Subscribing.

Subscribing.

subscribing

Where are we in moving toward a stable release and what can we do to help? Some work time or funding is available.

^{benjamin, Agaric Design Collective}

Yes, interested in a 6.0 release. Does the maintainer have any requests from users?

Hello,

I am also waiting.

Thanks a lot.

@Benjamin: Sounds like your best bet would be to contact Stefan or Daniel at Unleashed Mind for any commercial matters. Unfortunately there doesn't seem to be any love involved here but commercial interest might kick things off again. Hopefully between you, there's enough client demand to fund the work and get this pushed through to a full release (here's hoping!).

Anyone else able to contribute or have clients that need this functionality and could help with a bounty?

+1 sub

Hi guys,
I've been wrestling for Drupal in spare hours once a week for almost two years know and I still feel absolutely newbie. I hardly know about programming and I even get confused when having to work out VIEWS...

However, what I DO know is that an invite function is absolutely essential for any Social Web and, I'd say, for the Drupal community as a whole, just like connecting with Facebook, Gmail and the lot.

As such I am willing to make the only contribution I can make within my limited resources - know-how, time and money - and I offer 30 € for a working final version of any of these modules. I know it's not much, but it's going just one step further than only subscribing, and with the intention to have more people making the same step. I saw the bounty being mentioned and this is a community, right?

Now, I would only need someone to tell me where and how to deliver my part of the bounty.

subscribe... need stable release

Created first alpha release:
http://drupal.org/node/438532