Problem/Motivation

There are changes required for Drupal 10 support which will also contain CKEditor 5.

See Upgrade coordination for modules providing CKEditor 4 plugins

Issue fork insert_view-3310922

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bhogue created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Drupal 10 & CKEditor5 integration » Wrong filter type prevents this from being used with CKEditor 5
Category: Feature request » Bug report
Priority: Normal » Critical
Issue tags: +Novice

All this needs is 

 *   type = Drupal\filter\Plugin\FilterInterface::TYPE_MARKUP_LANGUAGE,

to be changed to

 *   type = Drupal\filter\Plugin\FilterInterface::TYPE_TRANSFORM_IRREVERSIBLE,

(This has always been wrong!)

That's an easy fix! 😊

immaculatexavier made their first commit to this issue’s fork.

immaculatexavier opened merge request !3

immaculatexavier’s picture

immaculatexavier commented
Status: Active » Needs review

Committed in accordance with the proposed resolution stated in #2

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community

Looks great! 👍

RenatoG made their first commit to this issue’s fork.

renatog’s picture

renatog commented
Status: Reviewed & tested by the community » Fixed

Good catch. Merged to the dev branch. Thanks everyone for your contribution. Have a great day

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

@RenatoG: could you tag a new release? 🙏😊 That will help the ~3,000 sites using this module on Drupal 9.4 or 9.5 to make the switch to CKEditor 5!

renatog’s picture

renatog commented

@RenatoG: could you tag a new release? 🙏😊 That will help the ~3,000 sites using this module on Drupal 9.4 or 9.5 to make the switch to CKEditor 5!

For sure! New release is ready 2.0.1 😊👍

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Yay, thank you!

Documented at https://www.drupal.org/docs/core-modules-and-themes/core-modules/ckedito... 👍

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.