Interesting module!

It seems to work for me on adding but not updating.

Here is what I did.

Create new content type.
Added entity reference field that uses Single Value Inline Entityform
Specify Entityform Submission entity type and Bundle
Add node - works
Click edit - gives following error

Notice: Trying to get property of non-object in Entityform->defaultLabel() (line 1121 of /Applications/MAMP/htdocs/do_modules/d7_entityform_7_2/sites/all/modules/mine/entityform/entityform.module).
Warning: Creating default object from empty value in EntityformInlineEntityFormController->entityForm() (line 37 of /Applications/MAMP/htdocs/do_modules/d7_entityform_7_2/sites/all/modules/contrib/inline_entityform_form/include/entityform.inline_entity_form.inc).
EntityMalformedException: Missing bundle property on entity of type entityform. in entity_extract_ids() (line 7663 of /Applications/MAMP/htdocs/do_modules/d7_entityform_7_2/includes/common.inc)

Comments

bisonbleu’s picture

bisonbleu commented

Same error. But i'm not using Inline Entityform Form. Just Entityform.

I get this error (x4) when redirecting (using Rules) to node/add/my_content_type after a user as submitted a form.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

@bisonbleu,
Can you provide more information?

Do other forms work if you don't redirect via Rules? Does the form work if you disable that Rule?

Which version of entityform are you using?

bisonbleu’s picture

bisonbleu commented

@tedbow
I tracked the errors down to a taxonomy term I had just deleted but was still being used by auto_entitylabel.

Deleting the nodes which were using the missing token in their title made the errors disappear.

I believe this had nothing to do with Rules.

entity 7.x-1.3
entityform 7.x-2.0-beta2+7-dev
auto_entitylabel 7.x-1.2+4-dev

cafuego’s picture

cafuego commented

Hmmm... the module isn't currently smart enough to manage editing - I'm using it on commerce product line items and they're never edited. So not entirely surprised it can't cope with other use cases ;-)

@tedbow On node edit, do you need the module to show the previously submitted entityform submission, so that can be modified?

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

@tedbow On node edit, do you need the module to show the previously submitted entityform submission, so that can be modified?

@cafuego, I was actually just testing the module out. I created the Entityform module so I am just interested in related modules.

Since I am just testing it out don't add any functionality on my account.

cafuego’s picture

cafuego commented
Status: Active » Postponed

Well, it should be relatively easy to make editing work... I might have a go anyway one of these days ;-)

Setting the issue to postponed.

cafuego’s picture

cafuego commented
Status: Postponed » Needs review

It looks as if some of the data for the embedded entityform got overwritten. Specifically, the $form['#entity']->type (the embedded entityform type) is overwritten by the machine name of the field that holds the entity reference to the entityform.

I've added a pretty ugly override that sets this back to the actual entityform type and I can now create, edit and view nodes with an embedded entityform.