Problem/Motivation

Entity form complex widget is not rendering the entity label in proper language. It should consider page language fallbacks.

Proposed resolution

getEntityLabel method should use getTranslationFromContext to render label in proper language.
see: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Entity%21...

CommentFileSizeAuthor
#22 3306743-22.patch7.44 KBmichaelsoetaert
#21 3306743-21.patch1.54 KBmichaelsoetaert
#19 inline_entity_form-label_language_fallbacks-3306743-16.patch1.54 KBgaurav_manerkar
#18 inline_entity_form-label_language_fallbacks-3306743-15.patch1.51 KBgaurav_manerkar
#16 inline_entity_form-label_language_fallbacks-3306743-14.patch1.44 KBgaurav_manerkar
#13 inline_entity_form-label_language_fallbacks-3306743-10.patch729 bytesgaurav_manerkar
#9 inline_entity_form-label_language_fallbacks-3306743-9.patch2.46 KBdmitry.korhov
#8 inline_entity_form-label_language_fallbacks-3306743-8.patch2.54 KBdmitry.korhov
#4 3306743-1.patch1.04 KBgaurav_manerkar

Issue fork inline_entity_form-3306743

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gaurav.manerkar created an issue. See original summary.

gaurav_manerkar’s picture

gaurav_manerkar commented
Issue summary: View changes
gaurav_manerkar’s picture

gaurav_manerkar commented
Component: Documentation » Code
gaurav_manerkar’s picture

gaurav_manerkar commented
StatusFileSize
new 3306743-1.patch1.04 KB
gaurav_manerkar’s picture

gaurav_manerkar commented
Status: Active » Needs review

dmitry.korhov made their first commit to this issue’s fork.

dmitry.korhov opened merge request !55

dmitry.korhov’s picture

dmitry.korhov
Primary language English
Location Warsaw, Poland
commented
Title: Inline form complex widget doesnt work with language fallbacks. » Inline form complex widget does not support language fallbacks for titles
Issue summary: View changes
Issue tags: -Fallback behaviour +fallback, +localization
StatusFileSize
new inline_entity_form-label_language_fallbacks-3306743-8.patch2.54 KB

attaching patch from MR

dmitry.korhov’s picture

dmitry.korhov
Primary language English
Location Warsaw, Poland
commented
StatusFileSize
new inline_entity_form-label_language_fallbacks-3306743-9.patch2.46 KB

Updated patch according to latest changes (previous one was not applicable during composer install routine)

The last submitted patch, 4: 3306743-1.patch, failed testing. View results

The last submitted patch, 8: inline_entity_form-label_language_fallbacks-3306743-8.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 9: inline_entity_form-label_language_fallbacks-3306743-9.patch, failed testing. View results

gaurav_manerkar’s picture

gaurav_manerkar commented
StatusFileSize
new inline_entity_form-label_language_fallbacks-3306743-10.patch729 bytes
gaurav_manerkar’s picture

gaurav_manerkar commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 13: inline_entity_form-label_language_fallbacks-3306743-10.patch, failed testing. View results

gaurav_manerkar’s picture

gaurav_manerkar commented
Status: Needs work » Needs review
StatusFileSize
new inline_entity_form-label_language_fallbacks-3306743-14.patch1.44 KB

Status: Needs review » Needs work

The last submitted patch, 16: inline_entity_form-label_language_fallbacks-3306743-14.patch, failed testing. View results

gaurav_manerkar’s picture

gaurav_manerkar commented
StatusFileSize
new inline_entity_form-label_language_fallbacks-3306743-15.patch1.51 KB
gaurav_manerkar’s picture

gaurav_manerkar commented
StatusFileSize
new inline_entity_form-label_language_fallbacks-3306743-16.patch1.54 KB
dmitry.korhov’s picture

dmitry.korhov
Primary language English
Location Warsaw, Poland
commented
Title: Inline form complex widget does not support language fallbacks for titles » Inline form complex widget does not support language fallbacks for existing entities
michaelsoetaert’s picture

michaelsoetaert
Primary language Dutch
Location Belgium 🇧🇪
commented
Version: 8.x-1.x-dev » 3.x-dev
StatusFileSize
new 3306743-21.patch1.54 KB

Re-rolled patch against 3.x branch.

michaelsoetaert’s picture

michaelsoetaert
Primary language Dutch
Location Belgium 🇧🇪
commented
StatusFileSize
new 3306743-22.patch7.44 KB

Patch in comment #21 was re-rolled successfully, but depended on other code that has since been removed. The updated patch includes the code it was depending on.