Test-class ComplexWidgetRevisionsTest uses the namespace Drupal\inline_entity_form\Tests which means it isn't triggered by Testbot.

Attached patch changes the namespace to Drupal\Tests\inline_entity_form\FunctionalJavascript which should solve that (and also removes a double semi-colon).

CommentFileSizeAuthor
#2 ComplexWidgetRevisionsTest_incorrect_namespace-3118610-2.patch1.11 KBspokje

Comments

Spokje created an issue. See original summary.

spokje’s picture

spokje
Primary language Dutch
commented
StatusFileSize
new ComplexWidgetRevisionsTest_incorrect_namespace-3118610-2.patch1.11 KB

Patch attached

spokje’s picture

spokje
Primary language Dutch
commented
Assigned: spokje » Unassigned
Status: Active » Needs review 
08:48:04 Tests to be run:
08:48:04   - Drupal\Tests\inline_entity_form\FunctionalJavascript\ComplexWidgetRevisionsTest
08:48:04   - Drupal\Tests\inline_entity_form\FunctionalJavascript\TranslationTest
08:48:04   - Drupal\Tests\inline_entity_form\FunctionalJavascript\SimpleWidgetTest
08:48:04   - Drupal\Tests\inline_entity_form\FunctionalJavascript\ElementWebTest
08:48:04   - Drupal\Tests\inline_entity_form\FunctionalJavascript\ComplexWidgetTest
08:48:04   - Drupal\Tests\inline_entity_form\FunctionalJavascript\ComplexSimpleWidgetTest
08:48:04 
08:48:04 Test run started:
08:48:04   Monday, March 9, 2020 - 07:48
08:48:04 
08:48:04 Test summary
08:48:04 ------------
08:48:04 
08:48:41 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex   2 passes                                      
08:48:41 Drupal\Tests\inline_entity_form\FunctionalJavascript\Transla   1 passes                                      
08:48:56 Drupal\Tests\inline_entity_form\FunctionalJavascript\SimpleW   4 passes                                      
08:49:38 Drupal\Tests\inline_entity_form\FunctionalJavascript\Element   1 passes                                      
08:49:50 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex  11 passes                                      
08:52:09 Drupal\Tests\inline_entity_form\FunctionalJavascript\Complex   1 passes

6 Test-classes should be ran, 6 Test-classes _are_ ran.
Green Testbot

I'm happy with this one.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks for the patch.

Kind regards, Denis

  • geek-merlin committed 90350df on 8.x-1.x 
    Issue #3118610 by Spokje, DenisCi: ComplexWidgetRevisionsTest uses...
geek-merlin’s picture

geek-merlin
Primary language German
Location Freiburg, Germany
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.