This is a child issue of #2860796: Plan for contributed modules with Media Entity API in core.

Media Entity 1.x in contrib had a MediaInlineForm class that wasn't moved into core Media as part of #2831274: Bring Media entity module to core as Media module.

The purpose of this issue is to bring this class back inside IEF, similarly to what there is already happening here with NodeInlineForm.

Comments

marcoscano created an issue. See original summary.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Assigned: marcoscano » Unassigned
Status: Active » Closed (won't fix)

After going deeper, I discovered that what this class was doing is only setting the media thumbnail on save:

  /**
   * {@inheritdoc}
   */
  public function entityFormSubmit(array &$entity_form, FormStateInterface $form_state) {
    parent::entityFormSubmit($entity_form, $form_state);

    /** @var \Drupal\media_entity\MediaInterface $entity */
    $entity = $entity_form['#entity'];

    // Make sure media thumbnail is set correctly.
    $entity->automaticallySetThumbnail();

    if ($entity_form['#save_entity']) {
      $entity->save();
    }
  }

However, in Media core this ::automaticallySetThumbnail() doesn't exist as a public method anymore, and all the thumbnail saving is handled automatically during save/update.

So while conceptually we could add the class to be used in IEF, right now we don't really have any media-specific behavior we need to address. Because of that, I'm closing this, we can re-open it in the future if we discover something related to Media that we want to happen while using IEF.