Use autocomplete element for autocomplete feature

Okay I go look this. @see https://www.drupal.org/node/2418529

There's no patch here.

Its true ! yersterday i propose a patch promise ;)

Here is first patch.

+
+  $target = $instance->getConfigTarget();
+  $settings = $instance->getSettings();
+  $settings2 = entity_get_form_display('node', 'page', 'default')
+    ->getComponent('field_reference')['settings'];
+  $targetType = $instance->getSetting('target_type');
+  $targetBundle = $instance->getSetting('handler_settings')['target_bundles'];
+

- You are adding an extra newline.
- Variables must be snake_case, not camelCase. So $target_type, not $targetType
- You can't name a variable $settings2 :) Maybe go with $instance_settings and $widget_settings.

Oh actually that was some debugging code :/ missed that this morning will make a fix quick

Should look better now.

Thanks! This looks almost ready to go.

+    '#selection_settings' => ['target_bundles' => $instance->getSetting('handler_settings')['target_bundles']],

We need to confirm this behaves properly for the "all bundles allowed" use case.

The selection handler that receives these settings has the following comment:

      // For the 'target_bundles' setting, a NULL value is equivalent to "allow
      // entities from any bundle to be referenced" and an empty array value is
      // equivalent to "no entities from any bundle can be referenced".

The test would be to create an entity reference field with no bundles selected, test IEF with this patch to confirm the autocomplete still works.

Looks good to me. Thank you!

:)

Created a separate content type for test, if that's overkill i can maybe work on adding the field to the already available content types.

So didn't go over other tests before. Now targets the right button and changed my added field to not be required or i would had to made more changes and additions.

+++ b/src/Tests/InlineEntityFormComplexWebTest.php
@@ -293,6 +299,16 @@ class InlineEntityFormComplexWebTest extends WebTestBase {
+    // Add all remaining nodes from all bundles.
+    for ($i = key($bundle_nodes) + 1; $i < count($bundle_nodes) + key($bundle_nodes); $i++) {
+      $this->drupalPostAjaxForm(NULL, [], $this->getButtonName('//input[@type="submit" and @value="Add existing node" and @data-drupal-selector="edit-all-bundles-actions-ief-add-existing"]'));
+      $this->assertResponse(200, 'Opening reference form was successful.');

This for loop assumes NIDs increment by 1. Since this is usually the case we can't assume it will always be so.

This test will fail in environment where database will be configured to use different PK increment step.

Addressed #23.

Committed. Thank you.