Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.In inline_form_alter(), the variable_get() call is dependent on the $node_type, which is specified to come from $form['orig_type']['#value']. However, on several node forms that form value is empty (for what reason I'm not entirely certain). That results in the variable_get() call always returning false/0, so that form field always defaults to "Disabled".
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | inline-DRUPAL-5.type-settings.patch | 1.05 KB | sun |
| #1 | inline-DRUPAL-5--2.type-settings.patch | 1.68 KB | sun |
Comments
Comment #1
sunYou've successfully identified some cruft code from 4.7.x good ol' times.
Attached patch fixes this by implementing the same logic like Comment module in core. However, that logic is plain wrong and still a bug in Drupal 7.x, because
$form['identity']['type']is always set in the content-type form and I guess it should be!empty($form['identity']['type']['#default_value'])or similar, to prevent those fields from showing up on content-type creation forms and hence, prevent storing 'module_node_' variables.Comment #2
sunAny updates? Anyone able to test whether this patch does NOT break existing sites/configurations?