Fix coding standard for php strlen and substr:

From strlen to Unicode::strlen and substr to Unicode::substr Using Drupal\Component\Utility\Unicode.

CommentFileSizeAuthor
#2 3196455-2.patch3.26 KBdeepakkumar14

Comments

deepakkumar14 created an issue. See original summary.

deepakkumar14’s picture

deepakkumar14 commented
Status: Active » Needs review
StatusFileSize
new 3196455-2.patch3.26 KB

I have added patch for same.

guilhermevp’s picture

guilhermevp commented
Status: Needs review » Reviewed & tested by the community

The patch apply perfectly!

+1 RBTC

ufku’s picture

ufku commented
Status: Reviewed & tested by the community » Closed (won't fix)

Unicode functions are deprecated. Also the usages of substr and strlen in IMCE are safe with unicode paths because they are mainly used to detect relative paths. If you think they do cause bugs please change this to a bug report.