Show filebrowser as a permission [#1333734]

Hi, besides that you are serving a great module here - thanks! - there's one little issue that could probably be improved and that would be moving the "display file browser tab" from a proprietary setting into the core permission set, e.g. with permissions like these:

- see own file browser tab
- see any file browser tab

I'm aware that the second item can be solved by setting corresponding directory permissions and I haven't looked too deep into the code yet to estimate the complexity. Can you feed back two or three words on that? :) Thx!

Comments

Comment #1

ufku CreditAttribution: ufku commented 16 November 2011 at 17:10

If we include access permissions, site admins would have to use both permissions page and IMCE configuration page in order to give tab access to a user.
Think of giving the tab permission to a role that does not have any IMCE profile assigned. The role wouldn't get the tab because it doesn't have access to IMCE in the first place.
This kind of separated access configuration would be worse than the current case.

Comment #2

doitDave CreditAttribution: doitDave commented 1 December 2011 at 15:37

Hm, you are right at first sight. But personally, I see less problems in having to set a basic "see tabs" option once and nevertheless doing a more sophisticated setup with the roles thing. Would be a double check but I think it would not be too big of a problem for site builders.

All that would miss were a line in Readme.txt ("make sure to give the tab permissions to the desired roles as well").

Just in case you would agree at last, I could also propose a patch if you'd like. :)