Comments

ryross created an issue. See original summary.

ryross’s picture

StatusFileSize
new873 bytes

Adding a comment

  • ryross authored fcbf707 on 8.x-1.x
    Issue #2922556 by ryross: Include Google's recommended optimization
    
bceyssens’s picture

Version: 8.x-1.0 » 7.x-1.x-dev
Category: Feature request » Task
Status: Active » Patch (to be ported)

@ryross

I applied your patch after I extended it with some settings and the option to strip metadata from images.
Thanks again!

joseph.olstad’s picture

Category: Task » Feature request
Status: Patch (to be ported) » Needs review
StatusFileSize
new659 bytes
joseph.olstad’s picture

@bcyessens , can you please share your metadata stripping code?

joseph.olstad’s picture

hip shot

bceyssens’s picture

Status: Needs review » Needs work

@joseph.olstad,

Here’s the patch for D8: https://cgit.drupalcode.org/imagick/commit/?id=fcbf707

Could you finish backport?

joseph.olstad’s picture

ya I'm working on it now, ignore patch 7 it's broken

joseph.olstad’s picture

StatusFileSize
new4.2 KB

Ok here's the backport of the D8 commit.

It's got config settings for strip metadata, for image optimize and the install file has a variable_del for cleanup on uninstall.

This patch works.

joseph.olstad’s picture

Status: Needs work » Needs review
joseph.olstad’s picture

minor change here , default use image optimize to TRUE instead of FALSE

strip_metadata is defaulted to FALSE

joseph.olstad’s picture

@bceyssens thanks for the tip,

The D7 backport is complete , this would look great in a new release!

Thanks very much, great module!

joseph.olstad’s picture

StatusFileSize
new3.94 KB

Ok, this should be the last change I have to make.

A small change, moved the strip metadata down after the jpeg section as it is in D8.

also added a helpful comment for the strip metatag operation.

joseph.olstad’s picture

StatusFileSize
new3.94 KB

I knew 13 was an unlucky number.

changed form key:
from
image_strip_metadata
to
imagick_strip_metadata

that is all

joseph.olstad’s picture

Patch 15 is good , I think it is a keeper this time.

rats, one more change to make.

joseph.olstad’s picture

StatusFileSize
new3.95 KB

Ok patch 17 , this is the goods now.
17 is a lucky number

bceyssens’s picture

Status: Needs review » Fixed

@joseph.olstad, your latest patch is working as expected.
Thank you for your contribution!

joseph.olstad’s picture

woot! Thanks @bceyssens

Thanks also for your work on the D8 port, although I'm not using it (yet) it will come in handy when I do.

Great project / module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.