I've observed two separate behaviours with image editor and multi-value file fields:

1) On a clean install using simpltest.me images edited from a multiple value image field are added to the bottom of the list of files and the original is not removed.

2) On a large site with many modules when an image is edited for a second time (in a single node edit session) when returning from Pixlr, the image is lost. This does not affect single value fields.

Thanks for the great module and let me know if I can provide more info

thanks,
Neil

Comments

ncameron’s picture

ncameron commented
Related issues: +#2275293: Various editors: image not saving after edit
duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented
Priority: Major » Normal
Status: Active » Postponed (maintainer needs more info)
Related issues: +#2087669: "Image Editor Save" error

Neil,

Thank you for using the module and for the report.

1) Looks like the field was configured not to replace the image. Adding the edited one at the bottom is fine. Check the field settings for the "replace image" option.
2) I have added another related issue #2087669: "Image Editor Save" error - this commit http://cgit.drupalcode.org/imageeditor/commit/?id=87322f6 fixed the image saving on the second try. So please check that you are using the latest release (7.x-1.11) here.

UPDATE: Check the JS console of the browser for any messages.

Thanks
AndyB

ncameron’s picture

ncameron commented

Hi Andy,

Thank you so much for your quick response, I'll try the the latest version and get back to you with any console messages.

thanks,
Neil

ncameron’s picture

ncameron commented

Hi Andy,

I can confirm that #1 is not an issue, thanks for clarifying.

Re issue #2 we're using 7.x-1.11 and I'm not seeing any log messages.

I've tried to replicate using simplytest.me but I don't think it works with an external image editing tool.

I can confirm when "replace image" is not ticked this is not an issue.

Are you able to reproduce this?

thanks
Neil

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented
Status: Postponed (maintainer needs more info) » Active

Yep, I have reproduced the issue with the image not being saved after the second edit; fixing it now.

AndyB

  • duozersk committed 07c5e2b on 7.x-1.x 
    Fixed [#2296765] - Image Editor for Image field - edited image not saved...
duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented
Status: Active » Fixed

Neil,

It should be fixed in this commit - http://drupalcode.org/project/imageeditor.git/commit/07c5e2b

Thanks
AndyB

ncameron’s picture

ncameron commented

Hi Andy,

Thanks again for you quick response and quick fix. I've given it a quick test and it all appears to working well. We'll do some more thorough QA on it today with combinations of saving and editing and report back with any issues.

If ever you're passing through London, let me know and I'll buy you a pint.

thanks
Neil

duozersk’s picture

duozersk
he/him
Primary language Russian
Location Moscow
commented

Neil,

Thank you for the update - let me know about the testing results, be it all good or bad ;)

AndyB

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.