Problem/Motivation

When the external image uri is (temporarily) not available and no fallback image is configured, the image render array is still build. If the 'Link image to' option is set, this results in the rendering of an empty link

Proposed resolution

Don't render the link if the image path is invalid.

CommentFileSizeAuthor
#2 imagecache_external-dont_render_empty_image-2929943-2.patch706 bytestvoesenek

Comments

Tom Voesenek created an issue. See original summary.

tvoesenek’s picture

tvoesenek commented
Status: Active » Needs review
StatusFileSize
new imagecache_external-dont_render_empty_image-2929943-2.patch706 bytes

This patch should fix it.

idebr’s picture

idebr commented
Status: Needs review » Reviewed & tested by the community

I can confirm the issue. The patch correctly prevents the field from rendering an empty link.

BarisW’s picture

BarisW commented

Thanks for the patch, looks good!

  • BarisW committed 2db5999 on 8.x-1.x authored by Tom Voesenek 
    Issue #2929943 by Tom Voesenek, idebr, BarisW: Empty link rendered when...
BarisW’s picture

BarisW commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.