When I attempted to upgrade from 7.x-2.0-beta1, permissions for Imagecache External broke. As a result, I could not access the module configuration page as an administrator. This was because the 'administer imagecache external' permission was renamed in a4116be to 'Administer imagecache external'. Attempting to save the permission did not work.

I have attached a patch that renames the permission and also removes the old permissions that are no longer used. I'm marking this issue 'Major' because it is not possible to cleanly upgrade from an older version without manually changing the name of the permission in the database. This makes it very hard for most users to update the module.

Thanks in advance.

CommentFileSizeAuthor
#3 imagecache_external_permission_rename-2635874-3.patch1.1 KBvinmassaro
#2 imagecache_external_permission_rename-2635874-2.patch1.1 KBvinmassaro

Comments

vinmassaro created an issue. See original summary.

vinmassaro’s picture

vinmassaro commented
Status: Active » Needs review
StatusFileSize
new imagecache_external_permission_rename-2635874-2.patch1.1 KB
vinmassaro’s picture

vinmassaro commented
StatusFileSize
new imagecache_external_permission_rename-2635874-3.patch1.1 KB

Wrong # on the last one, here is the correct patch.

BarisW’s picture

BarisW commented
Status: Needs review » Reviewed & tested by the community

Looks good to me, thanks for the patch!

  • BarisW committed 30f818f on 7.x-2.x authored by vinmassaro 
    Issue #2635874 by vinmassaro, BarisW: Permission rename breaks upgrade...
BarisW’s picture

BarisW commented
Status: Reviewed & tested by the community » Fixed

Committed!

vinmassaro’s picture

vinmassaro commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.