When an invalid url is passed into imagecache_external_fetch(), a notice "undefined index 'host'" is thrown, because it is assumed that parse_url returns an array with that key. Adding a check that checks if the key is there (and not empty) fixes this. If the check fails, the URL is invalid (you must have a host) so we can return FALSE.

A patch is attached.

CommentFileSizeAuthor
#1 imagecache_external-check_if_host_is_not_empty-2.patch539 bytesmarty2081
imagecache_external-check_if_host_is_not_empty.patch520 bytesmarty2081

Comments

marty2081’s picture

marty2081 commented
StatusFileSize
new imagecache_external-check_if_host_is_not_empty-2.patch539 bytes

Corrected the patch.

BarisW’s picture

BarisW commented
Status: Active » Fixed

Thanks a lot for the patch. I fixed it in another way, but added the commit on your name.

<?php
  if (!($host = parse_url($url, PHP_URL_HOST))) {
    return FALSE;
  }
?>

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.