Simple "Switch Width and Height to match Long Sides" feature (as in FastStone Photo Resizer)

Not sure where this feature request really belongs, as this is quite a basic one - similar to what's described in #967198: Tutorial: How to achieve "Zoom to fill" ImageCache action as known from video players. but for the 7.x-1.0 branch.
At first, I quickly achieved this using a small custom module (which I called 'image_extra_styles') - but I thought It could be useful to share here since I almost always use imagecache_actions anyways, so maybe it could live in there too.
Here's this (simple) module code :

/**
 * @file
 * Extra image custom styles
 */


/**
 * Implement hook_image_effect_info()
 */
function image_extra_styles_image_effect_info() {
  $effects = array(
    'scale_match_long_sides' => array(
      'label' => t( 'Scale while switching width and height to match long sides' ),
      'help' => t( 'Inspired by the excellent FastStone Photo Resizer - operates like the "normal" scaling (maintain the aspect-ratio of the original image & if only a single dimension is specified, the other dimension will be calculated), but if the image is portrait and this style\'s width is bigger than its height (set for landscape images), the scaling will use its height for the image width (so that no dimension ends up being too small or too big).' ),
      'effect callback' => 'image_scale_match_long_sides_effect',
      'dimensions callback' => 'image_scale_match_long_sides_dimensions',
      'form callback' => 'image_scale_form',
      'summary theme' => 'image_scale_summary',
    ),
  );
  return $effects;
}


/**
 * Image effect callback; Scale an image resource while switching width and height to match long sides.
 *
 * @param $image
 *   An image object returned by image_load().
 * @param $data
 *   An array of attributes to use when performing the scale effect with the
 *   following items:
 *   - "width": An integer representing the desired width in pixels.
 *   - "height": An integer representing the desired height in pixels.
 *   - "upscale": A boolean indicating that the image should be upscaled if the
 *     dimensions are larger than the original image.
 *
 * @return
 *   TRUE on success. FALSE on failure to scale image.
 *
 * @see image_scale()
 */
function image_scale_match_long_sides_effect(&$image, $data) {
  // Set sane default values.
  $data += array(
    'width' => NULL,
    'height' => NULL,
    'upscale' => FALSE,
  );
  
  // Switch width and height to match long sides if needed
  // (that is : when processing a portrait image when requested scaling is landscape)
  _image_extra_styles_auto_switch_dimesions(array('width' => $image->info['width'], 'height' => $image->info['height']), $data);
  
  if (!image_scale($image, $data['width'], $data['height'], $data['upscale'])) {
    watchdog('image', 'Image scale failed using the %toolkit toolkit on %path (%mimetype, %dimensions)', array('%toolkit' => $image->toolkit, '%path' => $image->source, '%mimetype' => $image->info['mime_type'], '%dimensions' => $image->info['width'] . 'x' . $image->info['height']), WATCHDOG_ERROR);
    return FALSE;
  }
  
  return TRUE;
}


/**
 * Image dimensions callback; Scale while switching width and height to match long sides.
 *
 * @param $dimensions
 *   Dimensions to be modified - an array with components width and height, in
 *   pixels.
 * @param $data
 *   An array of attributes to use when performing the scale effect with the
 *   following items:
 *   - "width": An integer representing the desired width in pixels.
 *   - "height": An integer representing the desired height in pixels.
 *   - "upscale": A boolean indicating that the image should be upscaled if the
 *     dimensions are larger than the original image.
 */
function image_scale_match_long_sides_dimensions(array &$dimensions, array $data) {
  if ($dimensions['width'] && $dimensions['height']) {
    // Before scaling, switch width and height to match long sides if needed
    _image_extra_styles_auto_switch_dimesions($dimensions, $data);
    image_dimensions_scale($dimensions, $data['width'], $data['height'], $data['upscale']);
  }
}


/**
 * Helper function to automatically switch width and height to match long sides if needed,
 * when processing a portrait image when requested scaling is landscape.
 *
 * @param $dimensions
 *   Dimensions to be modified - an array with components width and height, in
 *   pixels.
 * @param $data
 *   An array of attributes to use when performing the scale effect with the
 *   following items:
 *   - "width": An integer representing the desired width in pixels.
 *   - "height": An integer representing the desired height in pixels.
 *   - "upscale": A boolean indicating that the image should be upscaled if the
 *     dimensions are larger than the original image.
 */
function _image_extra_styles_auto_switch_dimesions(array $dimensions, array &$data) {
  if ($dimensions['width'] && $dimensions['height']) {
    $image_is_portrait = false;
    if ($dimensions['width'] < $dimensions['height']) {
      $image_is_portrait = true;
    }
    if ($image_is_portrait && $data['width'] > $data['height']) {
      $data['old_width'] = $data['width'];
      $data['old_height'] = $data['height'];
      $data['height'] = $data['old_width'];
      $data['width'] = $data['old_height'];
    }
  }
}