Closed (fixed)
Project:
ImageCache Actions
Version:
7.x-1.x-dev
Component:
Canvas Actions Module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
19 Nov 2011 at 11:07 UTC
Updated:
12 Dec 2011 at 03:10 UTC
This error raises up when I activate a "Define Canvas".
| Comment | File | Size | Author |
|---|---|---|---|
| screenshot.png | 49.28 KB | raulmuroc |
Comments
Comment #1
dman commentedI can replicate that if a bogus color value was entered in the color field for the canvas.
'333333' works
'' empty string gives us a transparent border
'dfghsd' gives me the error you post.
Looks like it's time to add a validation callback to the color submission form.
Comment #2
dman commented:(
I tried to steal the validation from core image_effect_color_validate() but it's way too unforgiving.
I want colors to allow RRGGBBAA values . Looks like I have to write one.
Comment #3
dman commentedOK.
I've pushed a color validation routine into the color entry widget. In dev now.
This works by actually calling the parse_color function imagecache_actions_hex2rgba() and making sure it returns a valid result.
While I was there, also overhauled transparency support for canvases. You can have partial transparency on your backgrounds - if you so wish.
May have some side effects with old invalid settings? but this is an improvement. test.