I have opened an request for a new feature at imagecache_actions that requires a change to imageapi.

It would be useful if presets had the ability to override the JPEG quality option. Imagecache and imageapi would have to modifed. here are the patches for imageapi.

CommentFileSizeAuthor
#5 imageapi_924304.patch2.45 KBdrewish
#1 imageapi_924304.patch1.06 KBdrewish
imageapi_gd.module.patch861 bytescybis
imageapi.module.patch764 bytescybis
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

drewish’s picture

drewish CreditAttribution: drewish commented
FileSize
imageapi_924304.patch1.06 KB

What do you think about doing it this way? Since the setting is GD specific?

drewish’s picture

drewish CreditAttribution: drewish commented

Might make sense to merge this with #817290: Quality param.

cybis’s picture

cybis CreditAttribution: cybis commented
Status: Needs review » Closed (duplicate)

@drewish, this is great!

Your solution is simple and elegant. It makes what I’m trying to accomplish here much easier: #924270: imagecache_convert jpeg quality override.

Thank you.

Closing this issue and continuing the conversation here: #817290: Quality param

cybis’s picture

cybis CreditAttribution: cybis commented
Status: Closed (duplicate) » Needs review

Actually reopening this issue since patch in #1 here is different from #2 at #817290: Quality param.
Patch #1 here works great for me.

drewish’s picture

drewish CreditAttribution: drewish commented
FileSize
imageapi_924304.patch2.45 KB

merging #817290: Quality param over here.

cybis’s picture

cybis CreditAttribution: cybis commented

Patch #5 works great.

Its 'companion' patch over at Imagecahe Action has been rolled in the 6.x-2.x-dev release #924270: imagecache_convert jpeg quality override. But that functionality doesn’t work without the patch here and it’s causing confusion here #1113530: Changing jpg quality does not seem to work.

Any plans to roll patch #5 in?

cybis’s picture

cybis CreditAttribution: cybis commented
Status: Needs review » Patch (to be ported)
marcoka’s picture

marcoka CreditAttribution: marcoka commented

anoyne knows if that has made it into the d7 version of imageapi?
could it be that a d7 port is not possible without hacking core image module? i did not find a hook that would make quality changes possible.

j0rd’s picture

j0rd CreditAttribution: j0rd commented

I need this patch as well.

Bensbury’s picture

Bensbury CreditAttribution: Bensbury commented

This for D7 would be very handy.