Remove duplicate ALT and TITLE in <img> tag

Here is the patch, against beta5

Hi,
I've followed it through and altough theme_image_attach_body() and theme_image_attach_teaser() in beta5 have been replaced with theme_image_attach_node_attached() in the latest dev, the call to image_display() and ultimately theme_image_display() is the same, so the correction to theme_image_display() I described above is still valid.

I think you could make a claim that it is actually a fault in theme_image() in theme.inc, as this is where the ALT and TITLE attributes are added to the <img> tag followed by everything returned from drupal_attributes($attributes) which causes the doubling up. It may be more correct to fix it there, so that any module which calls theme_image() with ALT and TITLE in the $attributes array does not get duplicated values in the html. But I doubt if we can get theme_image() corrected so I think it is worth fixing Image module'e theme_image_display().

The patch in #1 still applies cleanly to the 2010-07-11 dev release.

Jonathan

Thanks for the commit.

Actually I think D7 theme_image() is OK. I've cut out just the important bits:

function theme_image($variables) {
  ...
  $alt = $variables['alt'];
  $title = $variables['title'];
  $attributes = $variables['attributes'];
  ...
    if (isset($alt)) {
      $attributes['alt'] = $alt;
    }
    if (isset($title)) {
      $attributes['title'] = $title;
    }
    ...
    return '<img' . drupal_attributes($attributes) . ' />';
  }
}

If both $variables['alt'] and $variables['attributes']['alt'] are defined then the $variables['alt'] value takes precedence because $attributes['alt'] is updated to this value. The IMG tag only takes values from $attributes, so there is no duplication.

The D6 version is:

function theme_image($path, $alt = '', $title = '', $attributes = NULL, $getsize = TRUE) {
  ...
    $attributes = drupal_attributes($attributes);
    return '<img src="'. check_url($url) .'" alt="'. check_plain($alt) .'" title="'. check_plain($title) .'" '. (isset($image_attributes) ? $image_attributes : '') . $attributes .' />';
}

which is where the duplication arises, because ALT appears on its own and can also be taken from $attributes.

As it is fixed in D7 do you think it is still worth raising a core D6 fix? Everyone is working hard for D7 and I don't want to make work if it would be viewed as wasting time and not worth fixing.