Closed (won't fix)
Project:
Image
Version:
6.x-1.2
Component:
image.module
Priority:
Minor
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
25 Jul 2012 at 06:28 UTC
Updated:
6 Aug 2012 at 08:55 UTC
Jump to comment: Most recent file
Comments
Comment #1
Jalandhar commentedHi,
I have created the patch for image module when the upload image module is enabled. Please see the attachment of patches which will copy or move the images as per the settings in /admin/settings/image.
If "Keep Original Image." is selected then the image will be copied from files folder to files/images folder and if it is not selected then it will be moved from files folder to files/images folder.
Comment #2
Jalandhar commentedUpdated the patch with the path of the module file
Comment #3
Jalandhar commentedComment #4
Jalandhar commentedUpdated the patch files with correct naming.
Comment #5
Jalandhar commentedComment #7
Jalandhar commentedAnother try at the patch.
Updated the patch files.
Comment #9
Jalandhar commentedAnother try at the patch
Comment #10
Jalandhar commentedComment #12
joachim commentedFrom what I gather, upload_image is not terribly compatible with this module.
Secondly, could you upload your changes as a single patch please?
Comment #13
Jalandhar commentedHi joachim,
Thanks for your information and reviewing my patch.
I have updated the changes with a single patch.
Please review my patch and let me know your suggestions.
Thanks,
Jalandhar.
Comment #14
Jalandhar commentedComment #16
joachim commentedYour latest, single patch doesn't contain the same changes as the earlier pairs of patches.
Also, you should roll patches from the base folder of the project, not the base of Drupal, as otherwise the testbot fails to apply them.
> When I upload an image in file attachments and list that image
I'm still not sure why this is a problem in this module though. I thought http://drupal.org/project/upload_image's purpose was to move files from being uploaded attachments to being image nodes.
Comment #17
Jalandhar commentedHi joachim,
If I have used the url of image(sites/default/files/[image-name]) in some of the nodes of my site but when I list the images later then that images path is moving from sites/default/files/[image-name] to sites/default/files/images/[image-name] which results the image is not displaying in the node.
Updated the patch with the base folder of the project
Comment #18
Jalandhar commentedComment #20
Jalandhar commentedComment #21
Jalandhar commented#17: changed_image_module_for_upload_image_issue-1699572-17.patch queued for re-testing.
Comment #23
Jalandhar commentedsorry for my mistake. wrong syntax given for patch.
Comment #25
joachim commented> If I have used the url of image(sites/default/files/[image-name]) in some of the nodes of my site but when I list the images later then that images path is moving from sites/default/files/[image-name] to sites/default/files/images/[image-name] which results the image is not displaying in the node.
What you're doing is incompatible with how upload_image module works.
You should fix this with a custom module to react to hooks, or use another system for your images.