weird messages in search page - had missing derivative image which has been regenerated [#164194]

Hi, after I am searching something (or anybody), on page with search results I got these messages.
I did nothing with images, this comes after I upgrade image on 1.4, and 1.x dev version.

* The image Peter, Igorik a Slon had missing derivative image which has been regenerated.
* The image Dve kočky, 1 bicykel, a 1 Igorík. To sa ale niekto má. had missing derivative image which has been regenerated.
* The image Atmosphere - Igorik, Martini, Zuzka had missing derivative image which has been regenerated.
* The image Náhodne okolosediaci Igorík s voľne stojacimi Japonkami ktoré ho strážia pred ukradnutím had missing derivative image which has been regenerated.
* The image Igorík s Katánim prekonáva nástrahy prírody had missing derivative image which has been regenerated.
* The image Akcia SomvPrahe.sk v na Karaoke v Klube Meloun - Peter, Tamara, Igorik had missing derivative image which has been regenerated.

Igor
somvprahe.sk

Comments

Comment #1

skelly commented 12 August 2007 at 02:26

This appears to occur whenever your original image has equal or smaller dimensions than one of the defined derivative images (thumbnail, preview, custom). The _image_build_derivatives function exits prematurely without creating a derived image in this instance.

Earlier versions of this function seem to have simply copied (duplicated) the original file to be the derivative in the instance when the derivative dimensions were as large or larger than the original. Later versions now simply exit the function when this occurs leaving no derivative consructed and the warning to be re-emitted next time a derivative image is needed for display.

In fact it doesn't seem logical that this function can exit prematurely if one of the derivative scaling operations fails and not attempt it for any remaining derivatives.

(I'll attach a copy of my workaround patch once I make it and someone can run with it to fix it properly)

Comment #2

drewish commented 12 August 2007 at 05:03

skelly, the idea is that if the original is smaller than the desired shape you don't need to do anything. the bug was that when the node was loaded the original image wasn't assigned back into the derivative image. take a look at the latest -dev. i think you'll find that the sizes are loaded correctly.