After looking at #3102514: Rebuild the config internal subsystem, it seems we're in the need of a config that spans on multiple lines, seems like requiring/recommending would be sensible.

CommentFileSizeAuthor
#11 consider_dependency_on_multiple_config_module_3107513_11.patch1.56 KBdavidjguru
#9 consider_dependency_on_multiple_config_module_3107513_7.patch1.56 KBdavidjguru
#7 define_new_controller_3119943_7.patch2.22 KBdavidjguru
#5 rebuild_the_config_form_3119479_5.patch4.91 KBdavidjguru
#3 consider_dependency_on_multiple_config_module_3107513_3.patch425 bytesdavidjguru

Comments

pcambra created an issue. See original summary.

davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
CreditAttribution: davidjguru as a volunteer and commented
Assigned: Unassigned » davidjguru

I think it would be a very interesting change (IMHO).

Now, after run drush cex, the humanstxt.settings.yml looks like this: 

content: "/* TEAM */\nYour title: Your name.\nSite: email, link to a contact form, etc.\nTwitter: your Twitter username.\nLocation: City, Country.\n[...]\n\n/* THANKS */\nName: name or url\n[...]\n\n/* SITE */\nLast update: YYYY/MM/DD\nStandards: HTML5, CSS3,..\nComponents: Modernizr, jQuery, etc.\nSoftware: Software used for the development\n" 
display_link: false

So I'm agree with the idea. I'm going to take this Issue and testing the Multiline config module: https://www.drupal.org/project/multiline_config

davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
CreditAttribution: davidjguru as a volunteer and commented
Status: Active » Needs review
Issue tags: +Quick fix
StatusFileSize
new consider_dependency_on_multiple_config_module_3107513_3.patch425 bytes

Add a new little patch with changes in the .info.yml file, as:

- Add the new core_version_requirement key.
- Add the new name of the setting form.
- Add as a new dependency the multiline_config contrib module.

pcambra’s picture

pcambra
he/him
Primary language Spanish
CreditAttribution: pcambra at Cambrico commented
Status: Needs review » Needs work

A few comments:

- Shouldn't we add a composer.json file for ensuring the dependencies?
- Is this all we need to do to use multiline config?
- The core_version_requirement should be in a different issue

davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
CreditAttribution: davidjguru as a volunteer and commented
StatusFileSize
new rebuild_the_config_form_3119479_5.patch4.91 KB

I Just upload a new patch with the new composer.json file and changes over the info.yml file.

Greetings,

David.

davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
CreditAttribution: davidjguru as a volunteer and commented
davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
CreditAttribution: davidjguru as a volunteer and commented
StatusFileSize
new define_new_controller_3119943_7.patch2.22 KB

This is the new patch.

davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
CreditAttribution: davidjguru as a volunteer and commented
davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
CreditAttribution: davidjguru as a volunteer and commented
StatusFileSize
new consider_dependency_on_multiple_config_module_3107513_7.patch1.56 KB
davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
CreditAttribution: davidjguru as a volunteer and commented
davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
CreditAttribution: davidjguru as a volunteer and commented
StatusFileSize
new consider_dependency_on_multiple_config_module_3107513_11.patch1.56 KB
davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
CreditAttribution: davidjguru as a volunteer and commented
Status: Needs work » Needs review
pcambra’s picture

pcambra
he/him
Primary language Spanish
CreditAttribution: pcambra at Cambrico commented
Status: Needs review » Needs work 
+++ b/composer.json
@@ -0,0 +1,38 @@
+  "support": {
+    "issues": "https://www.drupal.org/project/issues/humanstxt",
+    "source": "https://git.drupalcode.org/project/humanstxt"
+  },
...
+  "repositories": {
+    "drupal": {
+      "type": "composer",
+      "url": "https://packages.drupal.org/8"
+    }
+  }

Looking at other projects, they don't seem to be adding these bits

davidjguru’s picture

davidjguru
he/him
Primary language Spanish
Location Seville, Andalusia (Spain)
CreditAttribution: davidjguru as a volunteer and commented

Ok, I added it based on previous observations in "small" projects (https://git.drupalcode.org/project/robotstxt/-/blob/8.x-1.x/composer.json) and in "big" projects (https://git.drupalcode.org/project/lingotek/-/blob/8.x-2.x/composer.json).

But as you say, no problem, I take it back.

pcambra’s picture

pcambra
he/him
Primary language Spanish
CreditAttribution: pcambra at Cambrico commented

Ah, I see, let's ask what the repositories key is there for, we can keep the support.

pcambra’s picture

pcambra
he/him
Primary language Spanish
CreditAttribution: pcambra at Cambrico commented
Status: Needs work » Needs review

Ah! https://www.drupal.org/docs/8/creating-custom-modules/add-a-composerjson...

pcambra’s picture

pcambra
he/him
Primary language Spanish
CreditAttribution: pcambra at Cambrico commented 
+++ b/humanstxt.info.yml
@@ -3,4 +3,6 @@ type: module
+configure: humanstxt.admin_settings_form

This change should have been in #3119479: Rebuild the Config Form instead but let's get all merged

  • pcambra committed 6ed26b3 on 8.x-1.x authored by davidjguru 
    Issue #3107513 by davidjguru: Consider dependency on Multiline config...
pcambra’s picture

pcambra
he/him
Primary language Spanish
CreditAttribution: pcambra at Cambrico commented
Status: Needs review » Fixed

Merged, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.