Hi,
I've got httpbl set to check status on comment forms

and sure enough it's checking.

But it doesn't seem to stop blacklisted IP's posting.

Log excerpt

content 05/28/2009 - 07:29 Comment: added SMUbIzjYSwH. Anonymous view
warning httpbl 05/28/2009 - 07:29 133.23.196.48 was blacklisted ... Anonymous IP data

--

Sean Burlington
www.practicalweb.co.uk

CommentFileSizeAuthor
#6 httpbl_reject_comments_option.patch1.56 KBMichael-IDA
#3 httpbl_reject_comments_option.patch1.73 KBseanburlington

Comments

seanburlington’s picture

seanburlington commented
Title: Blaclisted IPS can still post » optionally reject posts from blaclisted IP's (instead of moderating)
Category: bug » feature

Hi,
OK I see what's happening now.

httpl puts comments from blacklisted IP's in the moderation queue - it would be good to document this.

As I moderate all posts anyway this has no effect for me.

What I'd like is the option for httpl to reject posts entirely.

I just want a smaller moderation queue.

Maybe I'll find time to add this myself....

--

Sean Burlington
www.practicalweb.co.uk

seanburlington’s picture

seanburlington commented
Version: 6.x-1.x-dev » 5.x-2.1

sorry - not paying enough attention.

I forgot this is running on a Drupal 5 site

seanburlington’s picture

seanburlington commented
Status: Active » Needs review
StatusFileSize
new httpbl_reject_comments_option.patch1.73 KB

Hi,
here's a patch that does what I want.

I moved the config check into the menu - so that I could re-use the _httpbl_check() function in hook_comment on validation.

Then just the extra config settings to make rejection optional.

Sean Burlington
www.practicalweb.co.uk

bryrock’s picture

bryrock commented
Status: Needs review » Closed (won't fix)

Not entertaining any D5 features at this time.

seanburlington’s picture

seanburlington commented

Oh well

Thanks for the module - and for closing the issue :-)

Michael-IDA’s picture

Michael-IDA commented
Assigned: praseodym » Unassigned
StatusFileSize
new httpbl_reject_comments_option.patch1.56 KB

Hi Bryan,

Patch in #3 blew chunks, I re-rolled Sean's changes against the current D5 rev. httpbl-5.x-2.2 .

Tested on a site that had 10,000+ comment spam submission in the last two months. Works well. Has blacklisted 400+ IP in the last two days.

Can you apply it? I know it's a pain, but there are plenty of sites that got caught not being able to upgrade from D5 to D6 because of modules not being up-rev'ed (or having broken upgrade paths).

Thanks,
Sam

Edit: typo

bryrock’s picture

bryrock commented
Assigned: Unassigned » praseodym
Status: Closed (won't fix) » Reviewed & tested by the community

Oh. I've never pulled a clone of httpbl 5.x nor do I have any local or remote test sites for it. Let me reach out to praseodym and see if he might take a look.

bryrock’s picture

bryrock commented
Version: 5.x-2.1 » 5.x-2.2
Priority: Normal » Minor
Status: Reviewed & tested by the community » Needs review

I probably won't commit this since I'm not ramped up to test it, and usage of httpbl 5.x has been below 50 sites for a year and is now below 30.

But I'm willing to invite others to test, if they so desire.

bryrock’s picture

bryrock commented
Issue summary: View changes
Status: Needs review » Closed (outdated)