If the libraries module is not enabled, then putting HTML Purifier into the sites/all/libraries directory is of no use. However the Status Report page doesn't reflect this fact, and reports an "OK" and the HTML Purifier version even when libraries is disabled.

It would be nice if the Status Report output could check for the libraries module if the HTML Purifier code was found in the libraries directory.

Comments

fonant’s picture

fonant commented
Title: Error if libraries location used by libraries module not enabled » Error if libraries location used, but libraries module not enabled
Anonymous’s picture

Anonymous (not verified) commented

In general, the Libraries module must be enabled in order for any library located in sites/all/libraries to be usable. This is by design.

fonant’s picture

fonant commented

Yes, indeed.

My comment is that the Status Report page test is not correct: it says the library is OK when the libraries module is not enabled.

Situation:

  • HTML Purifier module enabled.
  • HTML Purifier library installed into sites/all/libraries.
  • Libraries module not enabled.
  • HTML Purified module reports "library OK" <- this is wrong and misleading.
ezyang’s picture

ezyang commented
Status: Active » Needs work

OK, it sounds like the status checker should check if library is installed and fail if it is not.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Once we release a stable 1.0 version, could we implement support for Libraries 2.0 and make it a requirement for use of this module? It would make the hook_requirements a lot cleaner and easier.

heddn’s picture

heddn
Primary language English
Location Illinois
commented

Not that we would use it for hook_requirements since that would require csstidy library. However, we could use libraries 2.0 support to fix the issue in: #1817412: ExtractStyleBlocks requires invalid module. Or at least explore it for possibilities...

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs work » Needs review

This should also fix the issue here: http://drupalcode.org/project/htmlpurifier.git/commit/b4d7206bf4ed75e171...

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Status: Needs review » Fixed

I'm going to say this is fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.