Create a configuration screen for HTML5 Tools options

Here's the first try at implementing a configuration page.

Things I'd like to discuss further:

• Is admin/config/system/html5_tools an acceptable path for this page?
• Should we provide checkboxes for the html5 widgets?
• Everything else I might have missed..

But, most important of all, I would really like some help with texts and descriptions :)

Instead of admin/config/system/html5_tools (always replace underscores with dashes in paths, btw), how about admin/structure/markup?

New patch that changes the path to admin/config/markup/html5-tools and the module description text.

Sorry, forgot to include html5_tools.admin.inc

And, finally, here is the final patch!

I think git is playing tricks on me. Another try :)

The IA placement is correct, hurray! :)

On admin/config, the text is a bit cryptic as it goes into detail on what the module does - how about "Configure how HTML5 markup is applied to your site."

+++ html5_tools.installundefined
@@ -10,6 +10,12 @@
+  variable_set('html5_tools_override_style_tags', 1);
+  variable_set('html5_tools_override_script_tags', 1);
+  variable_set('html5_tools_override_meta_tags', 1);

+++ html5_tools.moduleundefined
@@ -70,13 +110,13 @@ function html5_tools_field_widget_error($element, $error, $form, &$form_state) {
   // Cleanup markup by removing obsolete attributes.
-  if ($variables['element']['#tag'] == 'style') {
+  if (($variables['element']['#tag'] == 'style' || $variables['element']['#tag'] == 'link') && variable_get('html5_tools_override_style_tags', '')) {
     unset($variables['element']['#attributes']['type']);
   }
-  if ($variables['element']['#tag'] == 'script') {
+  if ($variables['element']['#tag'] == 'script' && variable_get('html5_tools_override_script_tags', '')) {
     unset($variables['element']['#attributes']['type']);
   }
-  if ($variables['element']['#tag'] == 'meta' && isset($variables['element']['#attributes']['http-equiv']) && $variables['element']['#attributes']['http-equiv'] == 'Content-Type') {
+  if ($variables['element']['#tag'] == 'meta' && isset($variables['element']['#attributes']['http-equiv']) && $variables['element']['#attributes']['http-equiv'] == 'Content-Type' && variable_get('html5_tools_override_meta_tags', '')) {
    $variables['element']['#attributes'] = array(
      'charset' => 'utf-8',

Most of the variable_gets should be before type/tags checks because they will short-circuit the evaluation :)

+++ html5_tools.admin.incundefined
@@ -0,0 +1,72 @@
+    '#default_value' => variable_get('html5_tools_override_script_tags', ''),

The default section for all the variable gets should be 0 instead of ''.

+++ html5_tools.admin.incundefined
@@ -0,0 +1,72 @@
+  $form['html5_tools_references'] = array(
+    '#markup' => t('<p>To learn more about HTML5, and to join the movement of using Drupal to create HTML5 websites, check out these resources.:</p>
+      <ul>
+        <li><a href="http://diveintohtml5.org/">Dive Into HTML5</li>
+        <li><a href="http://html5doctor.com/">HTML5 Doctor</li>
+        <li><a href="http://drupalradar.com/video-jeremy-keith-keynote-session">Jeremy Keith Keynote Session at Drupalcon Copenhagen</li>
+        <li><a href="http://groups.drupal.org/html5">Drupal HTML5 Group</li>
+      </ul>'),

Idk about these links. Maybe they're great resources but I don't think they belong in the module.

Powered by Dreditor.

Quick patch for eric's suggestions in #14.

And Bojhan's in #13 :)

The last patch looks good to me.

The links I mention as a question. Maybe Jen can chip in on her thought about the links. I'm ok with leaving them or removing them I just felt weird with them in the module.

Well, she wanted those links in the first place :) I'll leave them alone until something else is decided. Also, I forgot to change variable_get's from the configuration form.

I'm posting here a new patch for #1076512: HTML tools options screen error because we are already fixing some things from the config screen in this issue.

Fixed with http://drupalcode.org/project/html5_tools.git/commit/94fc2e5