I was looking at example_hotfolder module while working on a project that extended the hotfolder API and saw that it could use some love in the way of addressing a few typos, grammar mistakes and bringing it up to current Drupal code style standards.

CommentFileSizeAuthor
#5 hotfolder-exmple_hotfolder-fixes_typo_code_style_and_docs-2557373-5.patch15.38 KBdeetergp
#2 hotfolder-exmple_hotfolder-fixes_typo_code_style_and_docs-2557373-2.patch14.92 KBdeetergp

Comments

deetergp created an issue. See original summary.

deetergp’s picture

deetergp commented
StatusFileSize
new hotfolder-exmple_hotfolder-fixes_typo_code_style_and_docs-2557373-2.patch14.92 KB

I gave the Example Hotfolder (sub-) module a little love. I addressed a few spelling and grammar issues, fixed a couple syntax errors, brought the code up to current Drupal code style standards and rewrote the documentation in the hopes of making it a bit more clear and concise.

deetergp’s picture

deetergp commented
Status: Active » Needs review
sjpatrick’s picture

sjpatrick commented

Line 26 should be spelled with two asterisks. :-)

deetergp’s picture

deetergp commented
StatusFileSize
new hotfolder-exmple_hotfolder-fixes_typo_code_style_and_docs-2557373-5.patch15.38 KB

Not according to PHPCS with the Drupal & DrupalStandard standards. That isn't a docblock for a function, it's just a multiline comment that stands on its own. But after re-running PHPCS, I saw that I was missing type hints for $settings & $context. Fixed!

sjpatrick’s picture

sjpatrick commented
Status: Needs review » Reviewed & tested by the community

Groovy. Thanks for this. I know of a few other contrib modules that could use this kind of love. :-)

deetergp’s picture

deetergp commented

Thanks, sjpatrick!

  • deetergp committed 287f556 on 7.x-1.x 
    Issue #2557373 by deetergp: Fix code style issues in example module
deetergp’s picture

deetergp commented
Status: Reviewed & tested by the community » Closed (fixed)