Drupal 10, the latest version of the open-source digital experience platform with even more features, is here.The error logs are unclear why anything went wrong.
The system also tries to copy a file that is not there if the LE generate failed. It should check if the file exists before attempting to copy it.
Here's a screenshot of the errors on a fresh install of hosting_https. Note I am running locally, so I didn't expect it to pass, but I wanted to see what it said.
Also, we should try to avoid writing bad apache configs if the LE generate fails. Otherwise we can't restart apache at all!
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | 2968497-8-reduce_error_log_noice-and-show-warning-output.patch | 1.96 KB | helmo |
| #7 | 2968497-7-reduce_error_log_noice.patch | 1.43 KB | helmo |
| #3 | Screenshot from 2018-05-01 11-23-19.png | 223.83 KB | Jon Pugh |
| Screenshot from 2018-05-01 10-46-59.png | 183.78 KB | Jon Pugh |
Comments
Comment #2
Jon PughComment #3
Jon PughAfter successfully enabling Hosting HTTPS lets encrypt and getting my site on https, I changed the domain aliases to ones that had no DNS setup yet, and the LE generation failed, causing the chain of errors with the missing file copy and finally a failing apache restart.
The regular logs don't say anything about why. You should output something from LE in the regular warning log so users can take action.
Comment #4
colanThis is caused by the damage from #2912540: Reduce the number of log messages shown to the user.. When I reverse it by displaying all log types, all of the LE details come back. We need to fix that one ASAP.
Much of this was fixed in #2955062: Do not let nginx configuration reference missing cert files, but maybe we left out the Apache part. If so, let's rename and reopen until the Apache side is done.
Can we mark this one as a duplicate as the above two issues are / can be handled elsewhere?
Comment #5
Jon PughYou should include the "detail" from the JSON output so it would look like this:
or
Comment #6
helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commentedThe extra thing todo in this issue thats' not covered by the other two is to not to bother me that it failed to copy something when generating the cert failed in the first place.
Comment #7
helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commentedHere's a first patch to atleast change the 'Failed to generate Let's Encrypt certificates.' message to an error and stop trying to copy.
Comment #8
helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commentedChanging the command output to warning level when we have a problem also help to alleviate the #2912540: Reduce the number of log messages shown to the user. issue.
Comment #10
helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commentedCommitted.