The Hosting Task Logs output is way to verbose. We display all hosting log types, even debug messages.

I wanted to hide most of them, but I didn't know which ones. So I made it a setting:

hosting logs to display setting.

success logs

CommentFileSizeAuthor
Screenshot from 2017-09-28 16-25-29.png134.31 KBJon Pugh
Screenshot from 2017-09-28 16-22-53.png20.47 KBJon Pugh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Jon Pugh created an issue. See original summary.

  • Jon Pugh committed 20dc1d8 on 2912540-log-output 
    Issue #2912540: Clean up log output. Only show the configured log...
colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented

Would it be hard to switch to checkboxes, where they're all checked by default? Better UX I think.

Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location New Windsor NY
CreditAttribution: Jon Pugh at OpenDevShop Inc (CLOSED) commented

The available values are dynamic. Whatever goes into drush_log() gets saved there. That's why I didn't do checkboxes initially, in case someone wanted to set their own before we knew what the available log entries were. The hosting_log table might get deleted in some sites, so looking it up based on that isn't really reliable either.

I'm going to say that the Hosting Settings page is pretty advanced anyway, so maybe this is good enough for its intended audience?

  • Jon Pugh committed 20dc1d8 on 7.x-3.x 
    Issue #2912540: Clean up log output. Only show the configured log...
  • helmo committed f2f3ac7 on 7.x-3.x
    Issue #2912540: Merge remote-tracking branch 'origin/2912540-log-output...
helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commented
Status: Needs review » Fixed

Converting the UI to checkboxes might be nice as a followup, but this works.
Merged with only a whitespace fix

Jon Pugh’s picture

Jon Pugh
he/him
Primary language English
Location New Windsor NY
CreditAttribution: Jon Pugh commented

Awesome!!! Major usability improvement.

Thanks hello!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented
Assigned: Jon Pugh » Unassigned
Priority: Normal » Major
Status: Closed (fixed) » Needs work

This seems to change the default behaviour from showing everything to showing less, which should not be happening. Defaults should only change if the configuration has been changed by the user. For example, everyone's been complaining about HTTPS certificate generation problems stemming from #2952411: Restore Let's Encrypt log output in Verify tasks because they can no longer see what's going on, and have no idea why.

We need to reset this so that everything shows by default.

Unassigning Jon here so that anyone else can pick it up.

Workaround until this gets fixed:

  1. Hosting -> Settings
  2. In Task Logs to Display , cut the full list from the help text, and paste it over the current entries.
  3. Save the form.
  4. Full logs will now be displayed for new (and existing) tasks.

Also: Follow-up issue for the UX improvement is happening in #2960769: Add proper UX to the selector for choosing logs types to show.

helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commented

Since these values are dynamic we need some option to indicate 'ALL', any newly invented log type would otherwise be ignored.

What if we set the default value for hosting_task_logs_types_display to 'ALL' and extend the sql query to be something 'type IN (:types) OR show_all = :showall'

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented

Sounds good to me.

  • helmo committed e8fb753 on 7.x-3.x 
    Issue #2912540 by Jon Pugh, colan, helmo: Add the ALL type to get any...

  • helmo committed fe85d44 on 7.x-3.x 
    Issue #2912540 by Jon Pugh, colan, helmo: Set the default back to ALL,...
helmo’s picture

helmo CreditAttribution: helmo at Initfour websolutions for Aegir Cooperative commented
Status: Needs work » Fixed

This new commit adds a special type "ALL. And sets the default to that.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented

Great! Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.