I've been receiving the following respective warnings in drush_hosting_task() whenever verifying any site, platform, or server:

Parameter 1 to hosting_hosting_site_context_options() expected to be a reference, value given task.hosting.inc:130

Parameter 1 to hosting_hosting_platform_context_options() expected to be a reference, value given task.hosting.inc:130

Parameter 1 to hosting_hosting_server_context_options() expected to be a reference, value given task.hosting.inc:130

I've verified that on just-installed instance of Aegir, the frontend-triggered verify tasks generate these warnings (even on the verify tasks that pre-populate the task queue created by the hostmaster-install drush command).

If additional Aegir modules, like hosting_site_data or hosting_http_basic_auth, are enabled, you get additional similar warnings, for example, for hosting_http_basic_auth_hosting_site_context_options() and hosting_site_data_hosting_site_context_options(), respectively.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

JamesAn created an issue. See original summary.

JamesAn’s picture

Title: Invocation of hook_hosting_TASK_OBJECT_context_options doesn't pass $task by reference as expected » Invocation of hook_hosting_TASK_OBJECT_context_options() doesn't pass $task by reference as expected
Status: Active » Needs review
FileSize
606 bytes

The following patch follows a PHP.net documentation example found on the call_user_func() page demonstrating how to pass a variable by reference using call_user_func_array() instead.

All occurrences of the warning appear to be resolved with this small change.

  • helmo committed 5035a61 on 7.x-3.x authored by JamesAn
    Issue #2846897 by JamesAn: Invocation of...
helmo’s picture

Status: Needs review » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.