The last message in the task log (ex: Updated task status to "Successful") is always send with the drush_log type "info" instead of the result of the operation. It would probably be better if the type would be error for this line if the task is failed.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | give_the_last_message-2568643-2.patch | 1.15 KB | MartijnBraam |
Comments
Comment #2
MartijnBraam commentedPlease review the patch attached.
Comment #3
helmo commentedLooks good, although maybe the default should just be 'info'
Comment #5
helmo commentedCommited.
I also updated the default to info and satisfied the coder module.
A few remarks from the coder module:
Comment #7
gboudrias commentedComment #8
ergonlogicWhile I get the reasoning here, I don't know that this is actually a good idea. FWIW, this was how I'd initially implemented this message. The problem is that we're flagging a non-warning or non-error entry as such. I think this is actually misleading.
We have jump links that get you to the first relevant warning or error. I don't know what this would provide.
Sorry for commenting after the fact.
Comment #9
helmo commentedI think it's nice that it matches the overall result of a task.
But I agree with @ergonlogic that the line itself is not an error. And it could also be confusing if someone were to gather statistics on the number of errors.
So I don't object to reverting this.
Comment #11
helmo commentedI've reverted this ... sorry @MartijnBraam