If the following happens:

  • Server does not have SSL enabled
  • Platform is created on said server that does not have SSL enabled
  • Create a new site and select to enable SSL, and pick the platform on a server that does not have SSL enabled

Upon submission, the error that comes up is, "Please choose a valid profile" and "Please choose a valid platform." These errors are quite ambiguous for the actual problem at hand.

When this situation occurs, the user should understand the problem is related to enabling SSL.

CommentFileSizeAuthor
#7 form_error_message_is-2069431-7.patch1.53 KBhelmo
#6 form_error_message_is-2069431-6.patch1.49 KBhelmo

Comments

helmo’s picture

helmo commented
Project: Hostmaster (Aegir) » Hosting
Issue summary: View changes
Status: Active » Needs review

The form error has been fixed since ... but it can still be confusing.

A user who 'just' enables the hosting feature 'SSL' could use some extra hints to what the next steps should be ...

helmo’s picture

helmo commented
Version: 6.x-2.0-rc2 » 7.x-3.x-dev
Status: Needs review » Fixed

I've committed a hook that sets two messages.

See http://cgit.drupalcode.org/hosting/commit/?id=a6496b9

helmo’s picture

helmo commented
Issue tags: +aegir-ssl

Tagging...

Please feel free to re-open if a problem remains ... or if you have a suggestion to improve the messages.

ergonlogic’s picture

ergonlogic
he/him
Primary language English
Location Montréal, Québec 🇨🇦
commented
Status: Fixed » Needs work

This is still an issue. It occurs if the SSL Hosting feature is enabled, but no servers provide an ssh http service. It blocks installation of sites, as you cannot submit the form without errors being flagged. The errors are not at all helpful.

  • helmo committed a6496b9 on 7.x-4.x 
    Issue #2069431: Indicate next steps after enabling the SSL feature.
helmo’s picture

helmo commented
Status: Needs work » Needs review
Issue tags: +Aegir 3.1
StatusFileSize
new form_error_message_is-2069431-6.patch1.49 KB

Here's an extra patch to show a hint on the site edit form, and hide the bogus "(key deleted)" line on the site view page.

I could not reproduce the original form error, so I assume that's fixed.

helmo’s picture

helmo commented
StatusFileSize
new form_error_message_is-2069431-7.patch1.53 KB

On a site node create form we do not know if the platform that will be selected in on a server with SSL support.

I guess we would have to default to $ssl_available = TRUE;

updated patch.

gboudrias’s picture

gboudrias commented
Issue tags: -Aegir 3.1
helmo’s picture

helmo commented
Status: Needs review » Needs work

no longer applies

  • helmo committed d38663b on 7.x-3.x 
    Issue #2069431 by helmo: Do not show SSL form when SSL is not enabled on...
helmo’s picture

helmo commented
Status: Needs work » Fixed

I've re-worked it a bit and committed.
Also opened a merge request for the replacement https implementation: https://gitlab.com/aegir/hosting_https/merge_requests/6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.