Howdy,

I just tried to run hof.module on my site which uses a table name prefix and found a bunch of places where the table name isn't wrapped in {}. This patch just puts the table names in {} so that they'll work with a table name prefix.

Cheers,
Eric

CommentFileSizeAuthor
#2 hof.module.table_name.patch5.34 KBejort
poormanscron.module.wipe_messages_1.patch1.43 KBejort

Comments

baudolino’s picture

baudolino commented

Attached patch applies to poormanscron, not HOF :-)

ejort’s picture

ejort commented
StatusFileSize
new hof.module.table_name.patch5.34 KB

ah, crap. Clicked on the wrong file in my patch directory, sorry... This is the right one (I hope).

syscrusher’s picture

syscrusher commented

Good catch, ejort! This module started out as a hard-coded PHP-bodied book page -- written some time ago -- on one of my sites, and when I migrated the code to a real module, I overlooked that issue. Thanks for the patch. It has been accepted into HEAD, DRUPAL-4-5, and DRUPAL-4-6 versions of the HOF module.

Scott

ejort’s picture

ejort commented

No problems! I catch this error a lot as I have a 'cms-' table prefix. Thanks for the fast response, it's always fun to see my name flash through the cvs commit emails :)

Cheers,
Eric

syscrusher’s picture

syscrusher commented
Assigned: Unassigned » syscrusher
Anonymous’s picture

(not verified) commented