What is the status ?
Any chance for a D6 version?
(by the way, are users contributions identified by their Drupal account, or by a free text like in stand-alone EtherPad?)
Thanks
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | hackpad_for_D6.zip | 22.47 KB | jvieille |
| #12 | hackpad-d6-1858570-12.patch | 9.96 KB | bburg |
| #8 | 1858570.8-hackpad-backport-6.x.patch | 25.22 KB | deviantintegral |
| #6 | hackpad.tar_.gz | 11.7 KB | bburg |
| #4 | hackpad-6.x-0.x-dev.patch | 25.22 KB | bburg |
Comments
Comment #1
deviantintegral commentedThere's a chance, but I don't have a use for it myself. I'd be glad to review any work to backport it to D6. If you've got time to dedicate to it, let me know and I can connect you with our contact at Hackpad to enable API access until they make it public.
As of yesterday, users are identified by their username. It probably needs to be updated with a theme('username') call, and then stripping out HTML, so real names can be used on sites that use them.
Comment #2
bburgI am interested in working on a D6 backport for a project. I will ping you separately devientintegral for that contact.
Comment #3
bburgHere is my initial effort for a D6 backport. Still a few issues to address most likely. But I was able to get this running on a local D6 install.
Comment #4
bburgLet's try a version where the admin settings form isn't orphaned.
Comment #5
jvieille commentedThanks a lot, I would be ahppy to test this.
Would it be possible to attach a patched module?
Thanks
Comment #6
bburgArchived attached. I'll ping deviantintegral in a bit to add this as a proper module.
Also, fyi, looks like the D7 version needs a patch. Will try to get to this later.
Comment #7
deviantintegral commentedI did a quick read of the diff between the attachment and 7.x-1.x, and while I'm sure there are followups, it's far enough along I figured it was worth it to open a branch and at least have a proper version tag for the issue queue. I'll do a proper review and post comments soon.
Comment #8
deviantintegral commentedThis has already been committed; just posting again so I can review it with dreditor.
Comment #9
deviantintegral commentedSo here's a high level pass of the code. If we get these things fixed, I think we can close this issue and open up new ones for specific changes as you get them in place. I've avoided all code style issues, but I figure we can deal with those one the module is in a closer-to-working state.
Be sure to file any followup patches against the new branch now that it's been created.
Let's remove this disclaimer, and put it on the module home page instead.
We're missing a dependency on CCK (content.module).
This doesn't match the docblock. But if we don't need it, let's just remove it entirely?
Lets remove all commented code that isn't needed anymore from D7.
We should remove all console.log() calls as some browsers will throw errors if it's not defined.
Good catch. Submit a patch for the 7.x branch?
#attached was added for D7, and doesn't work in D6. We might just have to be broader and include hackpad.js on every page.
We should pull the hook_theme() implementation below up here so at least we start with it in the same place as the 7.x branch.
Let's use Autoload here to keep some consistency with D7.
https://drupal.org/project/autoload
Remove dpm()'s from the code so it doesn't break for site installs that don't have devel enabled yet.
I think this URL needs to be changed. As well, this text needs to be a t() call.
Agreed on removing these. It's just something nice for the admin UI, and it's not worth writing the custom code for a rarely used form.
Let's depend on ctools and use ctools_static() which is identical to drupal_static in D7.
Comment #10
bburgThanks a bunch for the feedback deviantintegral! I'll get to work on these this week.
Comment #11
jvieille commentedAs soon as a first dev module is issued, I'll glad to test it.
Thanks
Comment #12
bburg6.x-1.x Patch based on devientintegral's feedback. I a couple of issues to note:
-Since only the subdomain owner has permission to create pads in that subdomain, we will need to capture that user's email address, which is registered with the hackpad service in the global settings form so pads can be created on their behalf. Otherwise we get a HackpadRequestException thrown, which is not caught at the moment.
-Users keep being created in the hackpad service as "Anonymous" --For my own purposes, I created a separate patch that integrates with the realname module. There I called token_replace directly, but it may be nice to run usernames through theme_username(), to allow any rewriting. We will just need to filter out the html markup.
**Edit: I like to always include an install hook, even when there is no installation activity. This allows a module to be automatically installed in profiles.
Comment #13
jvieille commentedCan you submit the patched module?
Thanks
Comment #14
jvieille commentedI am testing this, using the moduel available in "view all releases" + path#12.
It does not work. When I do "test embedding" or create a node with a hackpad field, I get a blank screen with the text:
In the logs:
HackpadRequestException: Unauthorized in HackpadApi->request() (line 70 of /home/xxx/public_html/sites/all/modules/hackpad/includes/hackpad.api.inc).If I disable the line 70 in hackpad.api.inc :
the crash does not occur and I get the message "Domain id does not match request."
If I trace $response=>request with dpm():
Thanks for help
Comment #15
jvieille commentedI finally made it working:
1) changed this
2) The API key for the domain I set keeps changing : I just stay tuned to the current API key
Why is that???
3) only registered users can create pads
That is odd. I posted a separate issue for that
Comment #16
jvieille commentedActually, the D6 port is quite far from the D7 version.
I added all the missing stuff I found and got it working.
Should I hold waiting for an update, or continue to maintin the code on my side?
My working module is attached