PHPCS errors on scripts/ directory [#3255697]

Problem/Motivation

Child issue from https://www.drupal.org/project/gutenberg/issues/3255691
The idea here is to fix all phpcs errors/warnings from the files in the scripts/ directory.

Steps to reproduce

Open the Gutenberg module directory on your terminal and run the command: phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml scripts/ > phpcs_gutenber_scripts.txt. You should end up with a file like the one attached bellow.

Proposed resolution

Fix the errors either automatically or manually and create a patch.

Comment	File	Size	Author
#3	3255697-3.patch	6.69 KB	andregp
	phpcs_gutenberg_scripts.txt	2.27 KB	andregp

Comments

Comment #1

22 December 2021 at 19:40

andregp created an issue. See original summary.

Comment #2

andregp commented 22 December 2021 at 19:40

I'm working on a patch =)

Comment #3

andregp commented 22 December 2021 at 21:19

Assigned:	andregp	» Unassigned
Status:	Active	» Needs review

Status	File	Size
new	3255697-3.patch	6.69 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	phpcs_gutenberg_scripts.txt	2.27 KB

Here is the patch. The biggest change I had to do on the code was to move the generate-vendor.php constants to a dedicated interface in order to follow the phpcs standard and suppress the warning: Global constants should not be used, move it to a class or interface. I'm not sure though if this would be the best solution on the maintainers point of view.