Hi, I am not sure if this is intentional or not, but I am trying to go through some responses that have been graded already from my students and correct some things like keywords, however I am unable to edit their response becuase theAssignment response settings can not be changed from none and not set.

Is this done intentionally? I used to be able to edit students content after it was submitted I thought.

CommentFileSizeAuthor
#7 866780_edit_response_v2.diff11.99 KBMGN
#4 866780_edit_response.diff2.06 KBMGN

Comments

MGN’s picture

MGN commented
Category: support » bug
Status: Active » Fixed

No, it wasn't intentional. If teachers can edit the response node they should also be able to modify the response status settings. Thanks for reporting this.

I've just committed a fix to 6.x-2.x-dev.

AntiNSA’s picture

AntiNSA commented
Status: Fixed » Needs work

Ok, here is the current problem. I have students which have created responses to assighnments, and their are some errors I would like to correct, ie double content posting within the node, etc.

The problem is that the assignment reponse settings are set to none , and not set when I try to edit their response (even though they were not set to that setting and were correctly set when graded).. They have astericks which means if you dont set them you cant save the response after editing it.

Maybe the presents a problem when grading... If there could be a lock to allow editing after grade is issued, or a notificationin the gradebook that says new content after grade was issued, that could maybe solve the confusion.

But right now i cant edit responses from students, and I dont think they can edit their own response.

AntiNSA’s picture

AntiNSA commented

I hope youunderstand my meaning, and I have installed the latest dev version.

MGN’s picture

MGN commented
Status: Needs work » Needs review
StatusFileSize
new 866780_edit_response.diff2.06 KB

Yes. I see the problem now. Here is a patch that should solve the problem. I've only had time to test it on one example, so I would appreciate your feedback. If it works and you don't see any other problems, I'll commit it to 6.x-2.x-dev.

AntiNSA’s picture

AntiNSA commented

This is a response to assignment:

Still has no options to select, but us required on completed responses. It is possible to change response status though. Thanks for your effort on this

MGN’s picture

MGN commented
Assigned: Unassigned » MGN
Status: Needs review » Needs work

Thanks. After further inspection I found a few scenarios where this can happen. I am working on a solution.

MGN’s picture

MGN commented
Status: Needs work » Needs review
StatusFileSize
new 866780_edit_response_v2.diff11.99 KB

Ok, I think this should fix the problem. I've tested it on two sites from the student, teacher and administrators perspective. Teachers and administrator can edit the response after its graded, including the assignment options, but if they try to adjust the response status they will receive a notice indicating that this can now only be done through the gradebook (since the assignment has been graded). If students try to edit the response, they receive a notice indicating that only teachers can edit the response after it has been graded and the submit, preview and delete buttons are removed from the edit form. I think this should effectively preserve the response content that was graded while still giving teachers the ability to tweak it if necessary.

I feel I've done enough testing to commit this, but since there are so many possible scenarios here it would be helpful if you could test it first. This patch is against the current 6.x-2.x-dev version of gradebook_responses.module.

AntiNSA’s picture

AntiNSA commented

hmmm... I like it so far. It works as you have said. However, I have spent some time thinking about this and the thing is I want my students to be able to work collaboratory.. There is a lot of plans i have for their work that i cant take ownership of it after grading their work. If the teacher can only edit after gradeing that takes it too much away from the student for future development. The content is not only to be used for a grade, but the grade is sometimes an important part.

If there is some way to allow editing, and say that the grade represents the content that was available on this date and time, and detect the content has been updated so current grade can does not represent updated content, even providing a notification in the gradebook content updated since graded last that would be great. Also a field to say content updated since last grade and student requests or not requesting new grade...

I guess the ultimate would be to have a snapshot of the node content as graded be saved as a none changeable "Graded Version" for future reference... But that is not necessary.

As the system is now with the new way of updating content after a grade I just feel it takes to much control of content ownership away from the student.

AntiNSA’s picture

AntiNSA commented

I just noticed that while you can edit the content with the patch, there is a problem that you can not edit the user keywords. I have created with cck a field for user keywords... (under vocaublaries) and the field is empty when trying to edit the node. For i stance I have a student that thought that putting their embedded video code into the keyword thing was the right thing to do; I am unable to edit that to remove the embed code from the keyword field.

MGN’s picture

MGN commented
Status: Needs review » Needs work

Perhaps I should make the restrictions on editing a gradebook-level option. That way, those who want to prevent students from editing content after the grade has been given can enable the option, but the default will not attempt to restrict editing.

I'll modify the code to make this optional and then commit the changes for further review in 6.x-2.x-dev.

I am not sure about the problem in #9. I'll try to set something up to test and verify this.

AntiNSA’s picture

AntiNSA commented

Inst it possible to also notify that current version was edited since grade was issued, and the date it was edited? Displaying this info both on content and gradebook would be useful.

MGN’s picture

MGN commented

I can do this on the response node. For the gradebook, I could add a class identifier to the link to the response node that could be used to highlight the fact that the response node has been modified since it was last graded.

AntiNSA’s picture

AntiNSA commented

that would be great . when you do let me know and I iwill try to test it.

MGN’s picture

MGN commented
Status: Needs work » Fixed

This has been added in the latest 6.x-2.x-dev release.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.