I noticed whilst working on a local project and while not connected to www that if WebFont.load(Drupal.settings.google_webfont_loader_api_setting); is unsuccessful then it causes a JS error that breaks almost all the js on the page.

This is unlikely to ever be an issue on a production site unless the font provider is temporarily unavailable.

I'll make a patch next week.

Comments

btmash’s picture

btmash commented

Hiya,

Thanks for this crucial find, @mrsimonelliott. Were you able to make any progress on a patch?

btmash’s picture

btmash commented
Version: 7.x-1.9 » 7.x-1.x-dev
Status: Active » Fixed

I hadn't heard back so I've placed the Webfont.load into a try-catch block (where I write to the console if it cannot run Webfont.load). Looks to be working well so I've committed it to the dev branch. This will be a part of the next stable release (which...will probably be relatively soon unless any major issues come up).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.