Thanks for this module: very handy and quick to set up. However, the hook_block('view') produces invalid HTML, which can have impacts on cross-browser functionality and accessibility. There's two separate issues here:

1. The .tpl.php file is invalid e.g. attributes aren't quoted. Also the markup - especially the five paragraphs - make it hard to target specific bits of the form. There's also inline styles in the .tpl.php file, which can't be overridden by external CSS. Although this can be overridden in the theme layer, it's a shame to be required to do that to make one's own site valid XHTML.

2. $block['subject'] is set to '<none>'. Unfortunately, this isn't the same as putting '<none>' in the Drupal admin interface: what actually happens is '<h2><none></h2>' appears in the HTML, rather than no heading! What you need instead is to set the default block config as returned by hook_block('list')

Both of these can be fixed, in the theme layer and in Drupal admin respectively, but it'd be good not to have to do that.

I've attached a patch to address both of these issues.

CommentFileSizeAuthor
google_groups_patch.txt2.47 KBjp.stacey

Comments

dragonwize’s picture

dragonwize commented
Status: Active » Fixed

Thank you. I agree with most of your patch and have included it in the 2.x series.

The parts I left out were part of you HTML that was very site specific like a feildset and several additional divs and classes. The fieldset is styling that would very specific to a site plus if you have a long group name it completely breaks the layout. The rest can easily be added by anyone theming.

Please have a look at the 2.x series and let me know what you think.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.