http://pareview.sh/pareview/httpgitdrupalorgprojectgooglecurrencyconvert...

CommentFileSizeAuthor
#8 fix_the_coder_issues-2672608-8.patch3.44 KBshailu29
#6 fix_the_coder_issues-2672608-6.patch3.31 KBshailu29
#3 fix_the_coder_issues-2672608-3.patch3.29 KBborisson_

Comments

naveenvalecha created an issue. See original summary.

makbul_khan8’s picture

makbul_khan8 commented
Assigned: Unassigned » makbul_khan8
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Assigned: makbul_khan8 » Unassigned
Status: Active » Needs review
StatusFileSize
new fix_the_coder_issues-2672608-3.patch3.29 KB

I checked this with phpcs locally, this should be green for pareview.sh as well.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

patch is not applying anymore, needs a reroll

shailu29’s picture

shailu29 commented
Assigned: Unassigned » shailu29
shailu29’s picture

shailu29 commented
Status: Needs work » Needs review
StatusFileSize
new fix_the_coder_issues-2672608-6.patch3.31 KB

re-rolled

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs review » Needs work 
+++ b/src/Form/GoogleCurrencyConverterForm.php
diff --git a/src/GoogleCurrencyConverterManager.php b/src/GoogleCurrencyConverterManager.php
new mode 100755

this is not needed, please revert it back.
Rest looks good.

shailu29’s picture

shailu29 commented
Status: Needs work » Needs review
StatusFileSize
new fix_the_coder_issues-2672608-8.patch3.44 KB

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: shailu29 » Unassigned
Status: Needs review » Fixed

Thanks! Committed and pushed to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.