Ran drupal-check against 6050132.

 18/18 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ ---------------------------------------------------------------------------------------------------------------------
  Line   google_analytics.module
 ------ ---------------------------------------------------------------------------------------------------------------------
  521    Call to deprecated function file_prepare_directory():
         in drupal:8.7.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
  523    Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
  523    Call to deprecated function file_unmanaged_save_data():
         in drupal:8.7.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::saveData().
  526    Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
  526    Call to deprecated function file_unmanaged_save_data():
         in drupal:8.7.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::saveData().
  537    Call to deprecated constant FILE_CREATE_DIRECTORY: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::CREATE_DIRECTORY.
  537    Call to deprecated function file_prepare_directory():
         in drupal:8.7.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
  540    Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
  540    Call to deprecated function file_unmanaged_save_data():
         in drupal:8.7.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::saveData().
  543    Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
         \Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.
  543    Call to deprecated function file_unmanaged_save_data():
         in drupal:8.7.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::saveData().
  567    Call to deprecated function file_prepare_directory():
         in drupal:8.7.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
  568    Call to deprecated function file_scan_directory():
         in drupal:8.8.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.
 ------ ---------------------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------------------------
  Line   src/Tests/GoogleAnalyticsBasicTest.php
 ------ ----------------------------------------------------------------------------------------------------------------------
  15     Class Drupal\google_analytics\Tests\GoogleAnalyticsBasicTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  41     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ ----------------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------------------------------------------
  Line   src/Tests/GoogleAnalyticsCustomDimensionsAndMetricsTest.php
 ------ -------------------------------------------------------------------------------------------------------------------------------------------
  16     Class Drupal\google_analytics\Tests\GoogleAnalyticsCustomDimensionsAndMetricsTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  31     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ -------------------------------------------------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------------
  Line   src/Tests/GoogleAnalyticsCustomUrls.php
 ------ -----------------------------------------------------------------------------------------------------------------------
  13     Class Drupal\google_analytics\Tests\GoogleAnalyticsCustomUrls extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  26     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ -----------------------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------------------
  Line   src/Tests/GoogleAnalyticsPhpFilterTest.php
 ------ --------------------------------------------------------------------------------------------------------------------------
  16     Class Drupal\google_analytics\Tests\GoogleAnalyticsPhpFilterTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  31     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ --------------------------------------------------------------------------------------------------------------------------

 ------ ----------------------------------------------------------------------------------------------------------------------
  Line   src/Tests/GoogleAnalyticsRolesTest.php
 ------ ----------------------------------------------------------------------------------------------------------------------
  13     Class Drupal\google_analytics\Tests\GoogleAnalyticsRolesTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  26     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ ----------------------------------------------------------------------------------------------------------------------

 ------ -----------------------------------------------------------------------------------------------------------------------
  Line   src/Tests/GoogleAnalyticsSearchTest.php
 ------ -----------------------------------------------------------------------------------------------------------------------
  14     Class Drupal\google_analytics\Tests\GoogleAnalyticsSearchTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  29     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ -----------------------------------------------------------------------------------------------------------------------

 ------ -------------------------------------------------------------------------------------------------------------------------------
  Line   src/Tests/GoogleAnalyticsStatusMessagesTest.php
 ------ -------------------------------------------------------------------------------------------------------------------------------
  13     Class Drupal\google_analytics\Tests\GoogleAnalyticsStatusMessagesTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  28     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ -------------------------------------------------------------------------------------------------------------------------------

 ------ --------------------------------------------------------------------------------------------------------------------------
  Line   src/Tests/GoogleAnalyticsUninstallTest.php
 ------ --------------------------------------------------------------------------------------------------------------------------
  13     Class Drupal\google_analytics\Tests\GoogleAnalyticsUninstallTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  28     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  58     Call to deprecated function file_prepare_directory():
         in drupal:8.7.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
  71     Call to deprecated function file_scan_directory():
         in drupal:8.8.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::scanDirectory() instead.
  72     Call to deprecated function file_prepare_directory():
         in drupal:8.7.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\File\FileSystemInterface::prepareDirectory().
 ------ --------------------------------------------------------------------------------------------------------------------------

 ------ ---------------------------------------------------------------------------------------------------------------------------
  Line   src/Tests/GoogleAnalyticsUserFieldsTest.php
 ------ ---------------------------------------------------------------------------------------------------------------------------
  13     Class Drupal\google_analytics\Tests\GoogleAnalyticsUserFieldsTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  28     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ ---------------------------------------------------------------------------------------------------------------------------


 [ERROR] Found 34 errors
CommentFileSizeAuthor
#2 3119002-2.patch10.97 KBShreevasa Tantry

Comments

FatGuyLaughing created an issue. See original summary.

Shreevasa Tantry’s picture

Status: Active » Needs review
StatusFileSize
new10.97 KB

Please review the patch file.

Status: Needs review » Needs work

The last submitted patch, 2: 3119002-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Shreevasa Tantry’s picture

Assigned: Unassigned » Shreevasa Tantry
berdir’s picture

Status: Needs work » Closed (duplicate)

There is an existing RTBC issue #3072207: Drupal 9 compatibility for Google Analytics, check the issue queue before creating a new one.