Closed (fixed)
Project:
Google Analytics
Version:
5.x-1.5
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
25 May 2008 at 10:27 UTC
Updated:
19 Jun 2008 at 06:21 UTC
After upgrading to version 1.5, I could no longer configure google analytics. Browsing to the URL http://example.com/admin/settings/googleanalytics gave the following error:
warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'googleanalytics_admin_settings' was given in /home/example/drupal-5.7/includes/form.inc on line 218.
I'm using Drupal 5.7.
Comments
Comment #1
hass commentedFrom what version are you upgrading?
Have you run through
/update.php?Could you try to disable and re-enable the module? I haven't seen this while testing, but it sounds like a menu caching issue.
Comment #2
hass commentedYou MUST run the drupal upgrade process and I'm pretty sure you haven't done this (reproduced with upgrade from 1.3 to 1.5).
Comment #3
hass commentedComment #4
hass commentedComment #5
dshaw commentedThanks for all the tips. Turns out disabling/reenabling the module solved my problems.
Note: I definitely did run update.php yesterday immediately after I upgraded so that wasn't the problem. I upgraded from V1.4. You may want to update the issue title to reflect this.
Comment #6
hass commentedI will do another test with 1.4. As I know the update.php flushes the menu cache... but I'm not 100% sure and if this won't happen I shouldn't be able to verify that it works after running update.php and not before!?
Comment #7
rhylos commentedFYI, I had the same problem after upgrading and using update.php
I watched the progress bar during the update as well as saw no error messages during the update. It did reflect the successful updates that it applied.
I'm using:
W2k3 Sp2
IIS6
PHP 5.2.6
Drupal 5.7
MySQL 5.0.51a
Updated GA 1.4 to 1.5
Thanks for all the tips to get this going again.
Comment #8
hass commentedRemoved code. update.php clear the caches on D6 and D5... i wonder what could be wrong here.
Comment #9
hass commentedComment #10
hass commentedI'm still not able to reproduce this. I'm using PHP 5.2.6, MySQL 5.0.51b, WinXP, IIS 5.1, Drupal 5.7.
0. Uninstalled 1.5
1. Installed 1.3 or 1.4
2. Configured UA-1234-5
2a. Put site in maintaince
3. Deleted google_anaytics folder
4. Extracted 1.5
5. Clicked on admin/settings/googleanalytics -> Fails -> Expected behavior
6. Called update.php, run all updates
7. Go to Administration section and admin/settings/googleanalytics
8. All ok.
If you are able to reproduce this, we could try to add a fix if there is a bug.
Comment #11
dshaw commentedThe steps I performed were:
sites/all/modulessites/all/modulesadmin/logs/updates- confirmed at 1.5admin/settings/googleanalytics- error message encounteredSo I performed fewer steps and didn't put the site into maintenance.
I was able to repeat this fairly easily. If I rolled back to 1.4 the settings URL would work. If I upgraded it wouldn't.
Comment #12
hass commentedWhat caching settings do you have?
Caching enabled/disabled?
Time to cache?
Webserver?
Drupal version?
Are you able to debug this issue?
Comment #13
esbite commentedI also had this problem and solved it by disabling and enabling the module.
When disabling, it gave me this error
Comment #14
hass commented@thoughts: Is your error_reporting set to
E_ALL & ~E_NOTICE? See http://drupal.org/requirements.Comment #15
hass commentedCould someone try to add this to the end of googleanalytics.install v1.5 and try a upgrade from 1.4 or 1.3 to see if this fixes the problem? Please make sure you can reproduce the menu caching issue every time without the following code.
Comment #16
hass commentedComment #17
dshaw commentedI have "normal" caching enabled, with no minimum cache lifetime.
I'm using Drupal 5.7, Apache 2.0.x, PHP 5.2.x.
I also got the same error as Comment #13. Don't know if that helps.
Comment #18
hass commented@dshaw: see #14
Comment #19
dshaw commentedSorry, meant to report that to. From phpinfo()
error_reporting 6135, 6135 (i.e both master and local are 6135).
After searching php.net: E_ALL = 6143, E_NOTICE = 8
In hex: 0x17FF, 0x0008
0x17FF & ~0x0080 = 0x17F7
In Dec: 6135
So yes, it seems I have error reporting as E_ALL & ~E_NOTICE.
Comment #20
hass commentedIf you see this "warning" (not an error) you do not have
~E_NOTICEconfigured or you have removed this from core code. D5 and D6 is not EALL save and this is only a minor EALL issue that could be fixed very easily.Please focus on the menu caching issue.
Comment #21
hass commentedAdded code from #15 that hopefully fixes this issue.
Comment #22
dshaw commentedToday I upgraded five Drupal 5.7 sites to GA 1.6. Four went from 1.4->1.6, while the fifth went from 1.5->1.6. Four sites upgraded with no hitches. One site (going from 1.4->1.6) gave me the original error message when I first went to configure GA. Refreshing the page cleared the error and I was able to configure GA just fine. So things seems to have improved. And the fact that refreshing the page cleared the error, suggests caching was involved somehow.
Comment #23
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.