The give_record submodule is a legacy of following the core contact module in building Give, and bringing in the contact_storage module— give_record is directly analogous to contact_storage, but in the case of Give there doesn't seem to be a practical way to have the functionality offered by give_record, as it has evolved,

In theory the key functionality offered by the give_record module— donation forms as full entities that can be referenced (as from Paragraphs) and rendered in different view modes, and of course the recording of donations on the Drupal site (not with any financially identifying information) could be separated into a different module. But there doesn't seem to be any reason to, and as built the Give module depends on records being kept by Give record just to be able to work through the two-page donation process.

So it's best for Give Record to be merged into Give. Probably no need to change any database table names to do this. In any case a goal is not to have any impact on existing installs.

Comments

mlncn created an issue. See original summary.

gnuget’s picture

gnuget
Primary language Spanish
commented

Done.

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Active » Needs review
mlncn’s picture

mlncn commented
Status: Needs review » Fixed

Excellently done. Thank you.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

mlncn’s picture

mlncn commented 
Drupal\Core\Extension\Exception\UnknownExtensionException: The module[error]
give_record does not exist. in
/var/www/html/web/core/lib/Drupal/Core/Extension/ExtensionList.php:265
Stack trace:
#0
/var/www/html/web/core/lib/Drupal/Core/Extension/ExtensionList.php(579):
Drupal\Core\Extension\ExtensionList->get('give_record')
#1 /var/www/html/web/core/includes/update.inc(318):
Drupal\Core\Extension\ExtensionList->checkIncompatibility('give_record')
#2
/var/www/html/vendor/drush/drush/commands/core/drupal/update.inc(146):
update_get_update_list()
#3
/var/www/html/vendor/drush/drush/commands/core/core.drush.inc(466):
update_main()
#4 /var/www/html/vendor/drush/drush/includes/command.inc(422):
drush_core_updatedb()
#5 /var/www/html/vendor/drush/drush/includes/command.inc(231):
_drush_invoke_hooks(Array, Array)
#6 /var/www/html/vendor/drush/drush/includes/command.inc(199):
drush_command()
#7 /var/www/html/vendor/drush/drush/lib/Drush/Boot/BaseBoot.php(67):
drush_dispatch(Array)
#8 /var/www/html/vendor/drush/drush/includes/preflight.inc(67):
Drush\Boot\BaseBoot->bootstrap_and_dispatch()
#9 phar:///usr/local/bin/drush/bin/drush.php(153): drush_main()
#10 /usr/local/bin/drush(10): require('phar:///usr/loc...')
#11 {main}
Failed to execute command drush -y updb: exit status 1

This error happens on trying to run update hooks so i don't think an update hook will fix this, but if anyone has an old version of the module, you can get into your database MariaDB/MySQL what have you, as with `drush sqlc`, and fix it with this:

DELETE FROM key_value WHERE name = 'give_record';