I'm trying to track down why, but this module doesn't seem to play well with Omega base themes.

Comments

larseliasnielsen’s picture

larseliasnielsen commented

The problem is caused by hook_page_build(). It's set to render the github_ribbon() in $page['header']['github_ribbon'] and this dosen't exists in the theme.

This worked for me:
github.module, line 36-45:

/**
 * Implementation of hook_page_build()
 */
function github_page_build(&$page) {
  if (variable_get('github_username', '')) {
    $page['page_top'] = array(
      '#markup' => github_ribbon()
    );
  }
}
bhosmer’s picture

bhosmer commented

Good catch, and thanks for posting your solution. I never had a chance to go back and look at this and completely forgot about it.

What do you think would be the best way to fix this, since not all themes have a header region?

larseliasnielsen’s picture

larseliasnielsen commented

Unfortunately I was unable to find a proper solution to the problem.
The only thing I found was that system_region_list() can render the page blocks.

The reason I used $page['page_top'] is that according to html.tpl.php, page_top is used to render markup before all other dynamic content.

bhosmer’s picture

bhosmer commented

My thought was to use page_top as well, since if I remember correctly, that is present all the time.

larseliasnielsen’s picture

larseliasnielsen commented

page_top and page_bottom is by default shown in Drupal 7, but if html.tpl.php dosen't include them (which it should) (look here), the regions are not rendered.

The answer could be to check if the regions exists or let the user choose what block to display the ribbon in.
I've applied for maintainership of this module, so maybe I'll have the chance to make a proper solution for this issue.

bhosmer’s picture

bhosmer commented

Excellent work, and thanks for stepping up and taking over stewardship of this.

larseliasnielsen’s picture

larseliasnielsen commented
Priority: Normal » Major
Status: Active » Needs work
larseliasnielsen’s picture

larseliasnielsen commented
Status: Needs work » Fixed

This issue is now fixed with the new release. Let me know if you run into problems.

bhosmer’s picture

bhosmer commented
Status: Fixed » Needs work

With Omega 7.x-4.0-beta7 and 7.x-3.1 the banner shows, however the toolbar disappears upon activating github.

larseliasnielsen’s picture

larseliasnielsen commented

In the configuration page, what region have you placed the region in?
I can't seem to reproduce the error.

bhosmer’s picture

bhosmer commented
Status: Needs work » Reviewed & tested by the community

It happens on both left and right regions.

When you said "latest" I assumed you meant the latest release when I tested it out.

I went and pulled the latest from git, 251d26ebc31, and I don't see this error any longer.

Kudos for the third select box on the configuration options.

RTBC for me.

larseliasnielsen’s picture

larseliasnielsen commented

It occurred to me that the commit, where this bug was fixed, wasn't a part of the latest release, but I'm glad you figured this out yourself.
I've created a new release where this bug is fixed, as you saw when you pulled the repo.

Let me know if you find more bugs :)

bhosmer’s picture

bhosmer commented

Thanks for giving this the love it needed.

pravin ajaaz’s picture

pravin ajaaz commented
Issue summary: View changes
pravin ajaaz’s picture

pravin ajaaz commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.