naushunaushad [naushunaushad]

• The Login/Logout Destination module does something similar to this.
• Please read this: http://drupal.org/node/231036.
• You need not have version, project, datestamp in your .info file. They are automatically added by drupal.org
• The first line in your .info file isn't correct, it should be: ; $Id$

• In logout_redirect.module:
  Line 84: The parameters for form validation and submission functions have changed to $form, &$form_state (http://drupal.org/node/144132#process-params)
• You have an action form, but I don't see any place to set the URL. Please implement hook_menu.
• Also, for your hook_help, you need hook_menu. So implementing of hook_menu resolves two issues.
• Bunch of indent problems, from coder:

  Line 24: Use an indent of 2 spaces, with no tabs
  switch ($path) {

  Line 25: Use an indent of 2 spaces, with no tabs
  // Main module help for the logout_redirect module

  Line 26: Use an indent of 2 spaces, with no tabs
  case 'admin/help#logout_redirect':

  Line 27: Use an indent of 2 spaces, with no tabs
  return '

  ' . t('This module working with core modules action and trigger.
  

  Line 34: Use an indent of 2 spaces, with no tabs
  }

  Line 39: use a space between the closing parenthesis and the open bracket
  function logout_redirect_action_info(){

  Line 40: Use an indent of 2 spaces, with no tabs
  $actions['logout_redirect_action'] = array(

  Line 41: Use an indent of 2 spaces, with no tabs
  'description' => t('Redirect to a URL after logout'),

  Line 42: Use an indent of 2 spaces, with no tabs
  'type' => 'user',

  Line 43: Use an indent of 2 spaces, with no tabs
  'configurable' => TRUE,

  Line 44: Use an indent of 2 spaces, with no tabs
  'hooks' => array(

  Line 45: Use an indent of 2 spaces, with no tabs
  'user' => array('logout'),

  Line 46: Use an indent of 2 spaces, with no tabs
  )

  Line 47: Use an indent of 2 spaces, with no tabs
  );

  Line 48: Use an indent of 2 spaces, with no tabs
  return $actions;

  Line 57: use a space between the closing parenthesis and the open bracket
  function logout_redirect_action(&$object,$context){

  Line 57: missing space after comma
  function logout_redirect_action(&$object,$context){

  Line 58: Use an indent of 2 spaces, with no tabs
  drupal_goto($context['logout_redirect_url']);

  Line 66: Use an indent of 2 spaces, with no tabs
  $form['logout_redirect_url'] = array(

  Line 67: Use an indent of 2 spaces, with no tabs
  '#type' => 'textfield',

  Line 68: Use an indent of 2 spaces, with no tabs
  '#title' => t('URL'),

  Line 69: Use an indent of 2 spaces, with no tabs
  '#default_value' => $context['logout_redirect_url'],

  Line 70: Use an indent of 2 spaces, with no tabs
  '#size' => '60',

  Line 71: Use an indent of 2 spaces, with no tabs
  '#maxlength' => '90',

  Line 72: Use an indent of 2 spaces, with no tabs
  '#required' => TRUE,

  Line 73: Use an indent of 2 spaces, with no tabs
  '#description' => t('The URL to which the user should be redirected after logout. This can be an internal URL like node/1,login.html etc or an external URL like http://drupal.org.

  Line 75: Use an indent of 2 spaces, with no tabs
  );

  Line 76: Use an indent of 2 spaces, with no tabs
  return $form;

  Line 85: Use an indent of 2 spaces, with no tabs
  return array(

  Line 86: Use an indent of 2 spaces, with no tabs
  'logout_redirect_url' => $form_state['values']['logout_redirect_url'],

  Line 87: Use an indent of 2 spaces, with no tabs
  );

Your current .info with line numbers is:

1) ; $Id: logout_redirect.info, 2010/10/29 10:43:00 $  
2) name = 'logout_redirect'
3) description = Provide an action for redirection after logout.
4) core = 6.x

5) project = "logout_redirect" 
6) datestamp = "1288423416" 

• you must not have anything in between "Id" and "$". So your line number 1 should just contain: ; $Id$
• Remove the lines 5 and 6, you must not have them. They are automatically generated by drupal.org when you upload the module as a project.

• In .module file, remove everything you have and replace it with: // $Id$
• api.drupal.org is your friend, http://api.drupal.org/api/drupal/developer--hooks--core.php/function/hoo...
  

Well, you need not specially implement hook_menu for help. You need to implement hook_menu for a place, to set up the URL for redirection. As of now, there is no place I can set the URL, through Drupal front-end.

So please implement hook_menu for the form.

thanks naushunaushad.
Nice little module, solving what I couldn't do with other alternatives tried like Login/Logout Destination or Apache redirections rules.
It works as expected, allowing me to switch easly between https wth special port number and standart http.

Hello, and thank you for applying for a CVS account. I am adding the review tags, and somebody will report what needs to be changed.

As per requirements, the motivation should include a description of the module features (more than two sentences), and a comparison with the existing solutions.

Thank you for your reply.

Hi,
You module depends on the optional core module "Trigger". However, you .info file does not contain a dependency statement. Therefore, please consider adding the following line to your .info file dependencies[] = trigger.

Along the same lines, I would consider enhancing your hook_help implementation so that it provides a user links to core Actions and Triggers configuration settings dialogs.

Finally, the "coder" module reports several formatting issues. Otherwise, I tested the functionality, works as expected (nice work).

I am changing status as per previous comment.

Hi. Please read all the following and the links provided as this is very important information about your CVS Application:

Drupal.org has moved from CVS to Git! This is a very significant change for the Drupal community and for your application. Please read the following documentation on how this affects and benefits you and the application process:
Migrating from CVS Applications to (Git) Full Project Applications

• The status of this application will be put to "postponed" and by following the instructions in the above link, you will be able to reopen it.
• Or if your application has been "needs work" for more than 5 weeks, your application will be marked as "closed (won't fix)". You can still reopen it, by reading the instructions above.