Closed (fixed)
Project:
Git Rules
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
3 Jul 2011 at 20:28 UTC
Updated:
19 Jul 2011 at 09:21 UTC
First, thanks a million for this module. I've been looking for something like this -- simple, and flexible without the overhead of the project module. This fits the bill perfectly. Anyway, just wanted to point out a couple of bugs in the "repository exists" condition. First, it takes 2 arguments, but only uses 1 (it seems like only one is really needed). Second, it doesn't actually check if the named folder is a git repository, only that the folder exists. The attached patch gets rid of the "Repository" argument for this condition and checks that the named folder exists and is a git repository (either bare or not bare).
| Comment | File | Size | Author |
|---|---|---|---|
| git_rules-Repository_exists_condition_fixes.patch | 1.41 KB | rbayliss |
Comments
Comment #1
fabsor commentedYou are spot on =)
That repository checker was just a quick and dirty condition that I didn't really put that much thought to at the time, but now someone else has, which is a good thing ;)
Commited and pushed!