When a contrib module does not have core: 8.x in the .info.yml file but instead uses the new core_version_requirement, such as in Rules 8.x-3.x which has core_version_requirement: ^8.7.7 then Git Deploy produces

Notice: Undefined index: core in git_deploy_system_info_alter()
(line 33 of ... /git_deploy/git_deploy.module)

The error is unfortunate, but more critically, the module is removed from the Available Updates page altogether. If errors are written to the log and not to screen it just appears that the module is not installed.

Comments

jonathan1055 created an issue. See original summary.

jonathan1055’s picture

The $info array passed to git_deploy_system_info_alter() for the Rules module is:

info => Array
(
    [name] => Rules
    [type] => module
    [description] => React on events and conditionally evaluate actions.
    [package] => Rules
    [core_version_requirement] => ^8.7.7
    [dependencies] => Array
        (
            [0] => typed_data:typed_data
        )

    [configure] => entity.rules_reaction_rule.collection
    [core_incompatible] => 
    [mtime] => 1578058141
    [version] => 
    [php] => 7.0.8
)
darren oh’s picture

Status: Active » Closed (duplicate)
Related issues: +#1254200: Fix dev release time

The patch in #1254200-17: Fix dev release time fixes this. Please test and review.

jonathan1055’s picture

Thanks. I have tested the patch over on that other issue and it appears you have fixed it. Those modules without 'core' now show up correctly. I will report the full test on that other issue.