Replacing the zipball with the latest master branch code resolved fatal errors for me on the admin/modules page when having git --reference clones in the Drupal directory.

Resolution:

1) Make a new 1.1 tag.

2) Update README.txt and any auto-download code.

Comments

ohnobinki’s picture

ohnobinki commented

Proper fix would be: RESOLVED UPSTREAM. This module can't have a stable release until it can work against a stable version of glip. Thus there is no stable release and nothing can be done about it until upstream does.

I don't think that this is the proper place to request upstream to make a new release ;-).

chris.stone’s picture

chris.stone commented

Right now I'm back filling test cases for php's simpletest library into glip. I'm hoping that once we have a full test stack backing up glip we can get a stable release of git_deploy out. My fork is at chrisstone/glip and is based off halstead/glip master

ohnobinki’s picture

ohnobinki commented

My fork is at chrisstone/glip

Am I supposed to assume you're referring to http://github.com/ and not http://git.drupal.org/ ? :-p

and is based off halstead/glip master

So what if a user is writing a drupal module which requires vanilla glip to work? The whole libraries movement doesn't make sense when different drupal modules require forked versions of upstream libraries. As I've requested in #1054950: use official/stable releases of external libraries, only stable releases of upstream libraries should be used. I haven't seen anyone attempting to work with patrikf on defining glip. You might as well just not use the libraries API at all and incorporate it directly into the drupal module and stop calling it glip.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

I obviously meant to tag a new 1.1 release on github.

halstead's fork contains only one commit since 1.0, but that commit is essential to make git --reference caches work.

It is required for #1231254: Add a suggested 'clone' alias to example.drushrc.php for cached git_drupalorg clones + allow to set 'home' option

chris.stone’s picture

chris.stone commented

Sorry about not specifying http://github.com, when I wrote my post it seemed clear to me that it was in reference to github.com and not drupal.org :)

I'm not attempting to create a "hacked" glip in the sense of changing the functionality of the library. All I'm doing is adding in support for php's simpletest library. My fork is just as vanilla as halstead's is functionality wise. Granted I have moved the glip source from /lib to /classes in my fork "Easier for me to work with" sources will be moved back to /lib once I'm done backfilling test cases.

When I'm closer to completion, I will get with Patrick about merging the test suite into the official glip release.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

Subscribe. @halstead, would you be willing to appoint a comaintainer for this and the github repo?

Alternately, maybe it would be good to either move or fork the github repo to be here on d.o.

halstead’s picture

halstead commented

@rfay Absolutely. I haven't been able to give appropriate attention for ages. Freso is the only person who has asked and I've made him a co-maintainer.

Moving Glip to d.o. would be fine with me if someone does that I'll update the docs to point to new location.

halstead’s picture

halstead commented
Status: Active » Fixed

We are moving away from using glip but this has been fixed in glip 1.1. The readme has been updated with the new tag.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.