Needs review
Project:
Geofield
Version:
7.x-2.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
2 Dec 2012 at 14:15 UTC
Updated:
3 Apr 2015 at 14:45 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
basvredelingThe function can be replaced by:
This code needs refactoring into a separate function though. As is marked in openlayers_ui.admin.inc line 19: "// Todo: Rewrite properly and create a generic function to load all objects."
Don't forget to turn on the openlayers_geofield module.
Comment #2
basvredelingI've added a patch for geofield 7.x-2.x which should fix some more openlayers 3 issues all related to the map presets not being available.
Actually I think geofield needs a 3.x branch to match openlayers 3. That way, we don't break openlayers 2 compatibility.
Comment #3
milos.kroulik commentedThanks for the patch. Regarding the new branch - I don't think, it's a good idea, since Leaflet module (and possibly others) also uses Geofield. Generally, formatter modules should maintain compatibility with modules providing fields they operate on, not the other way around.
Comment #4
basvredelingIf we don't make another branch I propose we add another check for the OL version. Either:
or