Problem/Motivation
https://www.drupal.org/project/geocoder/issues/3521182 adds validation as follows:
// From \geocoder_field_form_field_config_edit_form_alter() in geocoder_field.module
$form['actions']['submit']['#validate'][] = 'geocoder_field_field_config_edit_form_validate';
Core and other modules add their validation to $form['#validate']. Adding validation on the submit button tells Drupal not to run validation directly on the form. So validation from Core and other modules is not run.
Steps to reproduce
Edit any entity field config from the UI. You can see what validations are being executed if you drop a breakpoint in \Drupal\Core\Form\FormValidator::executeValidateHandlers() and look at $handlers.
Proposed resolution
Move validation to $form['#validate'][] = 'geocoder_field_field_config_edit_form_validate';
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork geocoder-3624778
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
jasonsafro commentedComment #4
itamair commented#jasonsafro
It looks your MR !87 changes is reporting the code at the state when this old issue was raised and fixed:
https://www.drupal.org/project/geocoder/issues/3410082
Could you please double check that issue is not happening anymore, eventually?!
Comment #5
itamair commentedTested and no clear regressions found. Merged ...