Problem/Motivation

https://www.drupal.org/project/geocoder/issues/3521182 adds validation as follows:

// From \geocoder_field_form_field_config_edit_form_alter() in geocoder_field.module

$form['actions']['submit']['#validate'][] = 'geocoder_field_field_config_edit_form_validate';

Core and other modules add their validation to $form['#validate']. Adding validation on the submit button tells Drupal not to run validation directly on the form. So validation from Core and other modules is not run.

Steps to reproduce

Edit any entity field config from the UI. You can see what validations are being executed if you drop a breakpoint in \Drupal\Core\Form\FormValidator::executeValidateHandlers() and look at $handlers.

Proposed resolution

Move validation to $form['#validate'][] = 'geocoder_field_field_config_edit_form_validate';

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork geocoder-3624778

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jasonsafro created an issue. See original summary.

itamair’s picture

Status: Active » Postponed (maintainer needs more info)
Related issues: +#3410082: TypeError on Drupal 10.2.0

#jasonsafro

It looks your MR !87 changes is reporting the code at the state when this old issue was raised and fixed:
https://www.drupal.org/project/geocoder/issues/3410082

Could you please double check that issue is not happening anymore, eventually?!

itamair’s picture

Status: Postponed (maintainer needs more info) » Fixed

Tested and no clear regressions found. Merged ...

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.